From: David Miller <davem@davemloft.net>
To: auke-jan.h.kok@intel.com
Cc: akpm@linux-foundation.org, adobriyan@sw.ru,
randy.dunlap@oracle.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: 2.6.21-rc5-mm3: fix e1000 compilation
Date: Fri, 30 Mar 2007 14:20:25 -0700 (PDT) [thread overview]
Message-ID: <20070330.142025.02298139.davem@davemloft.net> (raw)
In-Reply-To: <460D4896.9090302@intel.com>
From: "Kok, Auke" <auke-jan.h.kok@intel.com>
Date: Fri, 30 Mar 2007 10:27:50 -0700
> turns out that NETIF_F_TSO6 is defined even if CONFIG_IPV6 is turned
> off, which is what broke e1000. That in itself might be a
> problem. Perhaps this should be fixed in netdevice.h (gratuitous bad
> inline patch below) but I'm not sure if people would appreciate
> this, as it's rather ugly, and it gets all horrible when people
> disable TCP protocol support...
No, I don't think we should do this.
We have the vlan acceleration flags available when 802.1Q is
disabled, same situation, and just as valid.
prev parent reply other threads:[~2007-03-30 21:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-30 8:50 2.6.21-rc5-mm3: fix e1000 compilation Alexey Dobriyan
2007-03-30 14:39 ` Kok, Auke
2007-03-30 15:05 ` Alexey Dobriyan
2007-03-30 17:01 ` Andrew Morton
2007-03-30 17:07 ` Randy Dunlap
2007-03-30 17:27 ` Kok, Auke
2007-03-30 21:20 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070330.142025.02298139.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=adobriyan@sw.ru \
--cc=akpm@linux-foundation.org \
--cc=auke-jan.h.kok@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).