From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@linux-foundation.org>,
linux-driver@qlogic.com, jgarzik@pobox.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: [-mm patch] make drivers/net/qla3xxx.c:PHY_DEVICES[] static
Date: Sat, 31 Mar 2007 22:55:40 +0200 [thread overview]
Message-ID: <20070331205540.GB14134@stusta.de> (raw)
In-Reply-To: <20070330010559.2a232d9a.akpm@linux-foundation.org>
On Fri, Mar 30, 2007 at 01:05:59AM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.21-rc5-mm2:
>...
> git-netdev-all.patch
>...
> git trees
>...
This patch makes the needlessly global PHY_DEVICES[] static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
BTW: Why is the name uppercase?
--- linux-2.6.21-rc5-mm3/drivers/net/qla3xxx.c.old 2007-03-31 21:30:20.000000000 +0200
+++ linux-2.6.21-rc5-mm3/drivers/net/qla3xxx.c 2007-03-31 22:02:00.000000000 +0200
@@ -88,7 +88,7 @@
char *name;
} PHY_DEVICE_INFO_t;
-const PHY_DEVICE_INFO_t PHY_DEVICES[] =
+static const PHY_DEVICE_INFO_t PHY_DEVICES[] =
{{PHY_TYPE_UNKNOWN, 0x000000, 0x0, "PHY_TYPE_UNKNOWN"},
{PHY_VITESSE_VSC8211, 0x0003f1, 0xb, "PHY_VITESSE_VSC8211"},
{PHY_AGERE_ET1011C, 0x00a0bc, 0x1, "PHY_AGERE_ET1011C"},
next prev parent reply other threads:[~2007-03-31 20:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070330010559.2a232d9a.akpm@linux-foundation.org>
2007-03-31 19:25 ` 2.6.21-rc5-mm3: Why was my vioc cleanup patch dropped? Adrian Bunk
2007-03-31 20:55 ` Adrian Bunk [this message]
2007-04-04 2:34 ` [-mm patch] make drivers/net/qla3xxx.c:PHY_DEVICES[] static Jeff Garzik
2007-04-04 17:11 ` Ron Mercer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070331205540.GB14134@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@linux-foundation.org \
--cc=jgarzik@pobox.com \
--cc=linux-driver@qlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).