From: Thomas Graf <tgraf@suug.ch>
To: David Miller <davem@davemloft.net>
Cc: ilpo.jarvinen@helsinki.fi, akpm@linux-foundation.org,
netdev@vger.kernel.org
Subject: Re: tcp crash in net-2.6 tree
Date: Mon, 2 Apr 2007 23:06:01 +0200 [thread overview]
Message-ID: <20070402210601.GS521@postel.suug.ch> (raw)
In-Reply-To: <20070402.020232.25465868.davem@davemloft.net>
* David Miller <davem@davemloft.net> 2007-04-02 02:02
> From: "Ilpo_Järvinen" <ilpo.jarvinen@helsinki.fi>
> Date: Mon, 2 Apr 2007 11:38:51 +0300 (EEST)
>
> > [PATCH] [TCP]: Fix invalid skb referencing in LOST marker code
> >
> > The after() referenced an invalid skb if loop exited when skb had
> > reached sk_write_queue. I chose to move this part inside the loop
> > where the skb is valid (so no need to check for that like I first
> > suggested), which also allows dropping of couple of conditions
> > from the if.
> >
> > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
>
> Patch applied, thanks a lot Ilpo.
I can no longer trigger the bug, thanks Ilpo.
prev parent reply other threads:[~2007-04-02 21:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-30 6:09 tcp crash in net-2.6 tree Andrew Morton
2007-03-30 14:33 ` Ilpo Järvinen
2007-03-30 16:18 ` Andrew Morton
2007-03-30 21:43 ` David Miller
2007-03-30 22:06 ` Andrew Morton
2007-03-30 22:12 ` David Miller
2007-03-30 22:10 ` Thomas Graf
2007-03-30 22:15 ` David Miller
2007-03-31 10:19 ` ijjarvin
2007-04-02 8:38 ` Ilpo Järvinen
2007-04-02 9:02 ` David Miller
2007-04-02 21:06 ` Thomas Graf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070402210601.GS521@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).