From: Ingo Molnar <mingo@elte.hu>
To: Ayaz Abdulla <AAbdulla@nvidia.com>
Cc: akpm@linux-foundation.org, jeff@garzik.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 10/10] forcedeth: work around NULL skb dereference crash
Date: Tue, 3 Apr 2007 08:26:29 +0200 [thread overview]
Message-ID: <20070403062629.GA13210@elte.hu> (raw)
In-Reply-To: <DBFABB80F7FD3143A911F9E6CFD477B0189CB20B@hqemmail02.nvidia.com>
* Ayaz Abdulla <AAbdulla@nvidia.com> wrote:
> I had responded eariler to the thread asking you to try out the patch
> found in bug 8058:
> http://bugzilla.kernel.org/show_bug.cgi?id=8058
>
> I believe that is the caush of the NULL skb dereference issue.
there's a different type of regression now: under high load i dont get a
crash, i get a hung interface instead. No error packets or other weird
interface state - just a hung interface. The condition happens after a
stream of:
eth1: too many iterations (6) in nv_nic_irq.
eth1: too many iterations (6) in nv_nic_irq.
eth1: too many iterations (6) in nv_nic_irq.
eth1: too many iterations (6) in nv_nic_irq.
eth1: too many iterations (6) in nv_nic_irq.
If i increase max_interrupt_work from 5 to 50 to paper over this
condition then the hangs go away. So i suspect there might still be a
queue-wakeup problem in one of these paths - or that a filled up tx ring
somehow gets stuck. (and i've got commits 3ba4d093fe8a26f and
fcc5f2665c81e08, so all the latest stuff that is upstream at the moment)
Ingo
next prev parent reply other threads:[~2007-04-03 6:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-27 5:47 [patch 10/10] forcedeth: work around NULL skb dereference crash akpm
2007-04-02 11:53 ` Ingo Molnar
2007-04-02 17:34 ` Ayaz Abdulla
2007-04-02 19:10 ` Ingo Molnar
2007-04-03 6:26 ` Ingo Molnar [this message]
2007-04-03 7:05 ` [bug] forcedeth: hung interface under load Ingo Molnar
2007-04-06 10:51 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070403062629.GA13210@elte.hu \
--to=mingo@elte.hu \
--cc=AAbdulla@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).