netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Olaf Hering <olaf@aepfle.de>
To: val_henson@linux.intel.com, andrew.patterson@hp.com,
	netdev@vger.kernel.org
Subject: [PATCH] fix MCA when shutting down tulip quad-NIC
Date: Tue, 3 Apr 2007 23:19:16 +0200	[thread overview]
Message-ID: <20070403211916.GA25570@aepfle.de> (raw)

From: andrew.patterson@hp.com

 https://bugzilla.novell.com/show_bug.cgi?id=SUSE39204

Shutting down the network causes an MCA because of an IO TLB error when
a DEC quad 10/100 card is in any slot.  This problem was originally seen
on an HP rx4640.


Signed-off-by: Olaf Hering <olaf@aepfle.de>

---

Andrew: Why is it tp->pdev instead of pdev?

 drivers/net/tulip/tulip_core.c |    1 +
 1 file changed, 1 insertion(+)

Index: b/drivers/net/tulip/tulip_core.c
===================================================================
--- a/drivers/net/tulip/tulip_core.c
+++ b/drivers/net/tulip/tulip_core.c
@@ -1798,6 +1798,7 @@ static void __devexit tulip_remove_one (
 		return;
 
 	tp = netdev_priv(dev);
+	pci_disable_device(tp->pdev);
 	unregister_netdev(dev);
 	pci_free_consistent (pdev,
 			     sizeof (struct tulip_rx_desc) * RX_RING_SIZE +

             reply	other threads:[~2007-04-03 21:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-03 21:19 Olaf Hering [this message]
2007-04-05 21:34 ` [PATCH] fix MCA when shutting down tulip quad-NIC Valerie Henson
2007-04-10 16:48   ` Olaf Hering

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070403211916.GA25570@aepfle.de \
    --to=olaf@aepfle.de \
    --cc=andrew.patterson@hp.com \
    --cc=netdev@vger.kernel.org \
    --cc=val_henson@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).