From: Tom Rini <trini@kernel.crashing.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: netdev@vger.kernel.org, shemminger@linux-foundation.org,
mhuth@mvista.com, kgdb-bugreport@lists.sourceforge.net
Subject: Re: [PATCH] netpoll: trapping fix/cleanup
Date: Wed, 4 Apr 2007 20:26:46 -0700 [thread overview]
Message-ID: <20070405032646.GG22371@smtp.west.cox.net> (raw)
In-Reply-To: <46130DD6.6050707@pobox.com>
On Tue, Apr 03, 2007 at 10:30:46PM -0400, Jeff Garzik wrote:
> Sergei Shtylyov wrote:
> > CONFIG_NETPOLL_TRAP causes the TX queue controls to be completely bypassed in
> > the netpoll's "trapped" mode which easily causes overflows in the drivers with
> > short TX queues (most notably, in 8139too with its 4-deep queue).
> > Make this option more sensible by only bypassing TX softirq wakeup and remove
> > CONFIG_NETPOLL_RX option completely since there is *no* code depending on it.
> >
> > Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
>
> ACK but (a) DaveM not me should apply this, and (b) I would check with
> netpoll people to see what that define is there for.
In terms of KGDB usage, I know Sergei has been trying to track down and
fix some issues (/make it more reliable) so if this does impact us I
know he'll be sending something along. ACK.
--
Tom Rini
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
prev parent reply other threads:[~2007-04-05 3:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-30 19:40 [PATCH] netpoll: trapping fix/cleanup Sergei Shtylyov
2007-04-04 2:30 ` Jeff Garzik
2007-04-04 13:03 ` Sergei Shtylyov
2007-04-05 3:26 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070405032646.GG22371@smtp.west.cox.net \
--to=trini@kernel.crashing.org \
--cc=jgarzik@pobox.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=mhuth@mvista.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).