From: Nishanth Aravamudan <nacc@us.ibm.com>
To: David Miller <davem@davemloft.net>
Cc: mchan@broadcom.com, torvalds@linux-foundation.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: tg3: unable to handle null pointer dereference
Date: Fri, 6 Apr 2007 18:53:01 -0700 [thread overview]
Message-ID: <20070407015301.GA9537@us.ibm.com> (raw)
In-Reply-To: <20070406.173600.38712619.davem@davemloft.net>
On 06.04.2007 [17:36:00 -0700], David Miller wrote:
> From: "Michael Chan" <mchan@broadcom.com>
> Date: Fri, 06 Apr 2007 15:57:13 -0700
>
> > On Fri, 2007-04-06 at 14:40 -0700, Nishanth Aravamudan wrote:
> >
> > > 2.6.21-rc5 is ok. 2.6.21-rc6 results in
> > >
> > > [ 14.241665] Unable to handle kernel NULL pointer dereference (address 0000000000000000)
> >
> > Sorry, I think this should fix it:
> >
> > [TG3]: Fix crash during tg3_init_one().
> >
> > The driver will crash when the chip has been initialized by EFI before
> > tg3_init_one(). In this case, the driver will call tg3_chip_reset()
> > before allocating consistent memory.
> >
> > The bug is fixed by checking for tp->hw_status before accessing it
> > during tg3_chip_reset().
> >
> > Signed-off-by: Michael Chan <mchan@broadcom.com>
>
> Applied, thanks Michael.
FWIW, tested, no panic.
Tested-by: Nishanth Aravamudan <nacc@us.ibm.com>
Thanks,
Nish
--
Nishanth Aravamudan <nacc@us.ibm.com>
IBM Linux Technology Center
next prev parent reply other threads:[~2007-04-07 1:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.64.0704051944230.6730@woody.linux-foundation.org>
2007-04-06 21:40 ` tg3: unable to handle null pointer dereference [Re: Linux 2.6.21-rc6] Nishanth Aravamudan
2007-04-06 22:57 ` Michael Chan
2007-04-07 0:36 ` tg3: unable to handle null pointer dereference David Miller
2007-04-07 1:53 ` Nishanth Aravamudan [this message]
2007-04-14 0:36 ` [1/3] 2.6.21-rc6: known regressions Adrian Bunk
2007-04-14 1:34 ` Linus Torvalds
2007-04-14 1:49 ` Brandeburg, Jesse
2007-04-14 4:25 ` David Miller
2007-04-14 5:07 ` Ian McDonald
2007-04-14 5:29 ` David Miller
2007-04-14 6:21 ` Ingo Molnar
2007-04-14 7:25 ` Greg KH
2007-04-20 13:39 ` Ingo Molnar
2007-04-20 13:46 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070407015301.GA9537@us.ibm.com \
--to=nacc@us.ibm.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).