From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: [PATCH 4/4] sky2: phy workarounds for Yukon EC-U A1 Date: Sat, 07 Apr 2007 16:42:09 -0700 Message-ID: <20070407234236.256434192@linux-foundation.org> References: <20070407234205.348565140@linux-foundation.org> Cc: stable@kernel.org, netdev@vger.kernel.org To: unlisted-recipients:; (no To-header on input) Return-path: Received: from smtp.osdl.org ([65.172.181.24]:36303 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752352AbXDGXoY (ORCPT ); Sat, 7 Apr 2007 19:44:24 -0400 Content-Disposition: inline; filename=sky2-ec-u-a1.patch Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org The workaround Yukon EC-U wasn't comparing with correct version and wasn't doing correct setup. Without it, 88e8056 throws all sorts of errors. Signed-off-by: Stephen Hemminger --- linux-2.6.20.y.orig/drivers/net/sky2.c 2007-04-07 15:56:37.000000000 -0700 +++ linux-2.6.20.y/drivers/net/sky2.c 2007-04-07 15:58:12.000000000 -0700 @@ -524,9 +524,9 @@ ledover &= ~PHY_M_LED_MO_RX; } - if (hw->chip_id == CHIP_ID_YUKON_EC_U && hw->chip_rev == CHIP_REV_YU_EC_A1) { + if (hw->chip_id == CHIP_ID_YUKON_EC_U && + hw->chip_rev == CHIP_REV_YU_EC_U_A1) { /* apply fixes in PHY AFE */ - pg = gm_phy_read(hw, port, PHY_MARV_EXT_ADR); gm_phy_write(hw, port, PHY_MARV_EXT_ADR, 255); /* increase differential signal amplitude in 10BASE-T */ @@ -538,7 +538,7 @@ gm_phy_write(hw, port, 0x17, 0x2002); /* set page register to 0 */ - gm_phy_write(hw, port, PHY_MARV_EXT_ADR, pg); + gm_phy_write(hw, port, PHY_MARV_EXT_ADR, 0); } else { gm_phy_write(hw, port, PHY_MARV_LED_CTRL, ledctrl); --