From: Olaf Hering <olaf@aepfle.de>
To: Valerie Henson <val_henson@linux.intel.com>
Cc: andrew.patterson@hp.com, netdev@vger.kernel.org
Subject: Re: [PATCH] fix MCA when shutting down tulip quad-NIC
Date: Tue, 10 Apr 2007 18:48:37 +0200 [thread overview]
Message-ID: <20070410164837.GB508@aepfle.de> (raw)
In-Reply-To: <20070405213415.GA22707@nifty>
On Thu, Apr 05, Valerie Henson wrote:
> On Tue, Apr 03, 2007 at 11:19:16PM +0200, Olaf Hering wrote:
> > From: andrew.patterson@hp.com
> >
> > https://bugzilla.novell.com/show_bug.cgi?id=SUSE39204
>
> Wow, registering for Novell's bugzilla is painful. And in the end I
> get "Access denied" on that bug. Can you give us this information
> some other way?
I did not see an easy way to make the bug public other than moving it to
the openSuSE category.
> > Shutting down the network causes an MCA because of an IO TLB error when
> > a DEC quad 10/100 card is in any slot. This problem was originally seen
> > on an HP rx4640.
>
> I'm not clear on why pci_disable_device() would fix this bug. Do you
> have an explanation (or can copy one out of the bug report)? I'm
> hesitant to make even obviously correct changes to the tulip driver
> without good evidence, given the incredible variety of buggy hardware
> out there.
The comments in the bug do not have an detailed analysis.
One of the comments is:
...
Comment #1 From Andrew Patterson 2004-04-20 19:47:32 MST [reply]
1. ifdown the interfaces; then ifup them
2. do this in a loop from a script and it generally MCA's within 2 minutes.
...
The first version for 2.6.5 contained the pci_disable_device()
and a version which was commited to mainline:
http://git.kernel.org/?p=linux/kernel/git/torvalds/old-2.6-bkcvs.git;a=commitdiff;h=6379dd571265528f3911b9deafe2a29af2e71a2b
Later the patch contained just the pci_disable_device() call.
Andrew, does your testscript still fail in SLES10 or mainline?
> This looks to me like another iteration of the shutdown DMA/irq race
> at first glance. Grant has a patch for it; I'm working on one I
> consider cleaner.
Thats likely the same issue.
http://www.linuxarkivet.se/mlists/linux-net/0409/msg00173.html
prev parent reply other threads:[~2007-04-10 16:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-03 21:19 [PATCH] fix MCA when shutting down tulip quad-NIC Olaf Hering
2007-04-05 21:34 ` Valerie Henson
2007-04-10 16:48 ` Olaf Hering [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070410164837.GB508@aepfle.de \
--to=olaf@aepfle.de \
--cc=andrew.patterson@hp.com \
--cc=netdev@vger.kernel.org \
--cc=val_henson@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).