From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: + ppp_generic-fix-lockdep-warning.patch added to -mm tree Date: Wed, 11 Apr 2007 00:09:32 -0700 Message-ID: <20070411000932.1f00f395.akpm@linux-foundation.org> References: <200703282353.l2SNr2iL023119@shell0.pdx.osdl.net> <01ef01c77bfe$4cdfe640$0202fea9@Jura> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: , , netdev@vger.kernel.org To: "Yuriy N. Shkandybin" Return-path: Received: from smtp.osdl.org ([65.172.181.24]:34587 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750712AbXDKHJt (ORCPT ); Wed, 11 Apr 2007 03:09:49 -0400 In-Reply-To: <01ef01c77bfe$4cdfe640$0202fea9@Jura> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org (added netdev) On Wed, 11 Apr 2007 09:57:33 +0400 "Yuriy N. Shkandybin" wrote: > I've tested 2.6.21-rc6-mm1 > Linux vpn1 2.6.21-rc6-mm1 #4 SMP Wed Apr 11 03:34:26 MSD 2007 x86_64 > Intel(R) Pentium(R) D CPU 2.80GHz GenuineIntel GNU/Linux > > warn appeares upon first pppoe connection to rp-pppoe server in kernel mode > > result: > ======================================================= > [ INFO: possible circular locking dependency detected ] > 2.6.21-rc6-mm1 #4 > ------------------------------------------------------- > pppd/14305 is trying to acquire lock: > (&vlan_netdev_xmit_lock_key){-...}, at: [] > dev_queue_xmit+0x26b/0x300 > > but task is already holding lock: > (&pch->downl#2){-+..}, at: [] ppp_push+0x5f/0xa7 > > which lock already depends on the new lock. > > > the existing dependency chain (in reverse order) is: > > -> #3 (&pch->downl#2){-+..}: > [] __lock_acquire+0xedf/0x1048 > [] lock_acquire+0x4f/0x78 > [] ppp_push+0x5f/0xa7 > [] _spin_lock_bh+0x2a/0x39 > [] ppp_push+0x5f/0xa7 > [] ppp_xmit_process+0x3d/0x590 > [] ppp_write+0x105/0x140 > [] vfs_write+0xa3/0xf0 > [] sys_write+0x47/0x75 > [] system_call+0x7e/0x83 > [] 0xffffffffffffffff > > -> #2 (&ppp->wlock){-+..}: > [] __lock_acquire+0xedf/0x1048 > [] lock_acquire+0x4f/0x78 > [] ppp_xmit_process+0x27/0x590 > [] _spin_lock_bh+0x2a/0x39 > [] ppp_xmit_process+0x27/0x590 > [] ppp_start_xmit+0x1cc/0x250 > [] dev_hard_start_xmit+0x22f/0x290 > [] __qdisc_run+0xd1/0x1f8 > [] dev_queue_xmit+0x288/0x300 > [] ip_mc_output+0x292/0x3f0 > [] raw_sendmsg+0x511/0x7c3 > [] inet_sendmsg+0x35/0x55 > [] sock_sendmsg+0xdf/0x102 > [] trace_hardirqs_on+0xc6/0x160 > [] autoremove_wake_function+0x0/0x46 > [] _spin_unlock_bh+0x2f/0x36 > [] release_sock+0xcd/0xd6 > [] ip_setsockopt+0x142/0xbb3 > [] verify_iovec+0x3c/0xc2 > [] sys_sendmsg+0x133/0x248 > [] trace_hardirqs_on+0xc6/0x160 > [] getrusage+0x1b8/0x1d9 > [] trace_hardirqs_on+0xc6/0x160 > [] trace_hardirqs_on_thunk+0x35/0x37 > [] system_call+0x7e/0x83 > [] 0xffffffffffffffff > > -> #1 (&dev->_xmit_lock){-+..}: > [] __lock_acquire+0xedf/0x1048 > [] lock_acquire+0x4f/0x78 > [] dev_mc_add+0x40/0x169 > [] _spin_lock_bh+0x2a/0x39 > [] dev_mc_add+0x40/0x169 > [] vlan_dev_set_multicast_list+0xa7/0x2b8 > [] __dev_mc_upload+0x24/0x26 > [] dev_mc_add+0xde/0x169 > [] igmp_group_added+0x56/0x5f > [] _write_unlock_bh+0x2f/0x36 > [] ip_mc_inc_group+0x105/0x17a > [] ip_mc_up+0x22/0x69 > [] inetdev_event+0x1b8/0x2f0 > [] notifier_call_chain+0x49/0x6b > [] __raw_notifier_call_chain+0x9/0xb > [] raw_notifier_call_chain+0x11/0x13 > [] dev_open+0x7d/0x80 > [] dev_change_flags+0x107/0x138 > [] devinet_ioctl+0x5cc/0x720 > [] dev_ioctl+0x1fc/0x31b > [] __up_read+0x3f/0x9d > [] inet_ioctl+0x5d/0x77 > [] sock_ioctl+0x4f/0x215 > [] do_ioctl+0x2a/0x83 > [] vfs_ioctl+0x62/0x2b0 > [] trace_hardirqs_on+0xc6/0x160 > [] sys_ioctl+0x41/0x65 > [] system_call+0x7e/0x83 > [] 0xffffffffffffffff > > -> #0 (&vlan_netdev_xmit_lock_key){-...}: > [] print_circular_bug_entry+0x49/0x59 > [] __lock_acquire+0xd53/0x1048 > [] kmem_cache_alloc+0x1a5/0x5e0 > [] trace_hardirqs_on+0x8a/0x160 > [] lock_acquire+0x4f/0x78 > [] dev_queue_xmit+0x26b/0x300 > [] _spin_lock+0x25/0x34 > [] dev_queue_xmit+0x26b/0x300 > [] __pppoe_xmit+0x1e8/0x265 > [] pppoe_xmit+0xc/0xe > [] ppp_push+0x74/0xa7 > [] ppp_xmit_process+0x3d/0x590 > [] ppp_write+0x105/0x140 > [] vfs_write+0xa3/0xf0 > [] sys_write+0x47/0x75 > [] system_call+0x7e/0x83 > [] 0xffffffffffffffff > > other info that might help us debug this: > > 2 locks held by pppd/14305: > #0: (&ppp->wlock){-+..}, at: [] > ppp_xmit_process+0x27/0x590 > #1: (&pch->downl#2){-+..}, at: [] ppp_push+0x5f/0xa7 > > stack backtrace: > > Call Trace: > [] print_circular_bug_tail+0x7c/0x91 > [] print_circular_bug_entry+0x49/0x59 > [] __lock_acquire+0xd53/0x1048 > [] kmem_cache_alloc+0x1a5/0x5e0 > [] trace_hardirqs_on+0x8a/0x160 > [] lock_acquire+0x4f/0x78 > [] dev_queue_xmit+0x26b/0x300 > [] _spin_lock+0x25/0x34 > [] dev_queue_xmit+0x26b/0x300 > [] __pppoe_xmit+0x1e8/0x265 > [] pppoe_xmit+0xc/0xe > [] ppp_push+0x74/0xa7 > [] ppp_xmit_process+0x3d/0x590 > [] ppp_write+0x105/0x140 > [] vfs_write+0xa3/0xf0 > [] sys_write+0x47/0x75 > [] system_call+0x7e/0x83 > > INFO: lockdep is turned off. Thanks. So you're saying that ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc6/2.6.21-rc6-mm1/broken-out/ppp_generic-fix-lockdep-warning.patch did not fix anything?