From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] net: Add etun driver Date: Wed, 11 Apr 2007 09:16:06 -0700 Message-ID: <20070411091606.04d73b31@freekitty> References: <1176136628.8459.34.camel@johannes.berg> <461A70A5.8060607@trash.net> <20070409.114402.45491411.davem@davemloft.net> <461A9DF1.8080904@trash.net> <1176150557.8459.47.camel@johannes.berg> <461AD517.2000906@trash.net> <1176239819.10381.10.camel@johannes.berg> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Patrick McHardy , "Eric W. Biederman" , David Miller , akpm@linux-foundation.org, dim@openvz.org, netdev@vger.kernel.org, jgarzik@pobox.com, containers@lists.osdl.org, kuznet@ms2.inr.ac.ru, greearb@candelatech.com To: Johannes Berg Return-path: Received: from smtp.osdl.org ([65.172.181.24]:50601 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752864AbXDKQRK (ORCPT ); Wed, 11 Apr 2007 12:17:10 -0400 In-Reply-To: <1176239819.10381.10.camel@johannes.berg> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Tue, 10 Apr 2007 23:16:59 +0200 Johannes Berg wrote: > On Tue, 2007-04-10 at 02:06 +0200, Patrick McHardy wrote: > > > Same way as the current RTM_SETLINK message works, but with creating > > a new link in advance. It works fine in other subsystems, so I don't > > see why it would in this case as well. Some subsystems do it in an > > atomic fashion (network schedulers for example), some first create > > the object, then configure it (network classifiers in the non-compat > > cases). In the network device case I suppose the later should work > > fine since a device needs to be set UP in a second action before > > it really does anything. > > Looking at br_netlink.c it seems that this sort of contradicts why > generic netlink was done, now all the sudden everything that wants to > create new links need its own netlink protocol number, no? > > johannes Bridging is different since there was already a bridge protocol number assigned, there was no point in doing generic netlink. --- Stephen Hemminger