From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: [patch 04/31] skge: turn carrier off when down Date: Wed, 11 Apr 2007 15:51:25 -0700 Message-ID: <20070411225125.GE24814@kroah.com> References: <20070411224329.866978349@mini.kroah.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Justin Forbes , Zwane Mwaikambo , Theodore Ts'o , Randy Dunlap , Dave Jones , Chuck Wolber , Chris Wedgwood , Michael Krufky , Chuck Ebbert , torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, netdev@vger.kernel.org, Stephen Hemminger To: linux-kernel@vger.kernel.org, stable@kernel.org Return-path: Content-Disposition: inline; filename="skge-carrier.patch" In-Reply-To: <20070411225100.GA24814@kroah.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org -stable review patch. If anyone has any objections, please let us know. ------------------ From: Stephen Hemminger Driver needs to turn off carrier when down, otherwise it can confuse bonding and bridging and looks like carrier is on immediately when it is brought back up. Signed-off-by: Stephen Hemminger Signed-off-by: Greg Kroah-Hartman --- drivers/net/skge.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/net/skge.c +++ b/drivers/net/skge.c @@ -2462,6 +2462,7 @@ static int skge_down(struct net_device * printk(KERN_INFO PFX "%s: disabling interface\n", dev->name); netif_stop_queue(dev); + netif_carrier_off(dev); if (hw->chip_id == CHIP_ID_GENESIS && hw->phy_type == SK_PHY_XMAC) cancel_rearming_delayed_work(&skge->link_thread); --