From: Willy Tarreau <w@1wt.eu>
To: David Miller <davem@davemloft.net>
Cc: tgraf@suug.ch, netdev@vger.kernel.org
Subject: Re: [IPv4] fib: Fix out of bound access of fib_props[]
Date: Sat, 14 Apr 2007 16:26:55 +0200 [thread overview]
Message-ID: <20070414142655.GA21327@1wt.eu> (raw)
In-Reply-To: <20070324.203339.71087299.davem@davemloft.net>
On Sat, Mar 24, 2007 at 08:33:39PM -0700, David Miller wrote:
> From: Thomas Graf <tgraf@suug.ch>
> Date: Sat, 24 Mar 2007 16:34:36 +0100
>
> > Fixes a typo which caused fib_props[] to have the wrong size
> > and makes sure the value used to index the array which is
> > provided by userspace via netlink is checked to avoid out of
> > bound access.
> >
> > Signed-off-by: Thomas Graf <tgraf@suug.ch>
>
> Applied, thanks.
Thomas, David, it seems to me that 2.4 needs the same fix for the
typo, but I see no place where we may add the check for > RTN_MAX.
Maybe this last one is not needed. If someone could enlighten me,
or at least provide a means to test if the bug it present, it would
help me.
Thanks in advance,
Willy
next prev parent reply other threads:[~2007-04-14 14:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-24 15:34 [IPv4] fib: Fix out of bound access of fib_props[] Thomas Graf
2007-03-25 3:33 ` David Miller
2007-04-14 14:26 ` Willy Tarreau [this message]
2007-04-14 15:48 ` Willy Tarreau
2007-04-16 8:14 ` Thomas Graf
2007-04-16 8:45 ` Willy Tarreau
-- strict thread matches above, loose matches on Subject: below --
2006-11-29 13:55 Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070414142655.GA21327@1wt.eu \
--to=w@1wt.eu \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).