From: David Miller <davem@davemloft.net>
To: kaber@trash.net
Cc: netdev@vger.kernel.org
Subject: Re: [NETLINK 01/04]: Switch cb_lock spinlock to mutex and allow to override it
Date: Mon, 16 Apr 2007 16:55:54 -0700 (PDT) [thread overview]
Message-ID: <20070416.165554.55726278.davem@davemloft.net> (raw)
In-Reply-To: <20070416074950.19262.97555.sendpatchset@localhost.localdomain>
From: Patrick McHardy <kaber@trash.net>
Date: Mon, 16 Apr 2007 09:51:53 +0200 (MEST)
> [NETLINK]: Switch cb_lock spinlock to mutex and allow to override it
>
> Switch cb_lock to mutex and allow netlink kernel users to override it
> with a subsystem specific mutex for consistent locking in dump callbacks.
> All netlink_dump_start users have been audited not to rely on any
> side-effects of the previously used spinlock.
>
> Signed-off-by: Patrick McHardy <kaber@trash.net>
Applied.
The call signature of netlink_kernel_create() is getting huge.
It's getting near the time we should pass in a descriotor
block in the form of a structure to specify all of these
parameters.
It would have even made this patch significantly smaller since the
default of NULL would have worked out perfectly.
next prev parent reply other threads:[~2007-04-16 23:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-16 7:51 [NETLINK 00/04]: Consistent dump callback locking Patrick McHardy
2007-04-16 7:51 ` [NETLINK 01/04]: Switch cb_lock spinlock to mutex and allow to override it Patrick McHardy
2007-04-16 23:55 ` David Miller [this message]
2007-04-17 10:40 ` Patrick McHardy
2007-04-16 7:51 ` [RTNETLINK 02/04]: Hold rtnl_mutex during netlink dump callbacks Patrick McHardy
2007-04-16 23:59 ` David Miller
2007-04-16 7:51 ` [RTNETLINK 03/04]: Remove unnecessary locking in " Patrick McHardy
2007-04-17 0:01 ` David Miller
2007-04-16 7:51 ` [NET_SCHED 04/04]: Eliminate qdisc_tree_lock Patrick McHardy
2007-04-17 0:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070416.165554.55726278.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).