From: David Miller <davem@davemloft.net>
To: kaber@trash.net
Cc: milon@wq.cz, akpm@linux-foundation.org, netdev@vger.kernel.org,
bugme-daemon@bugzilla.kernel.org
Subject: Re: [Bugme-new] [Bug 8320] New: replacing route in kernel doesn't send netlink message
Date: Mon, 16 Apr 2007 17:10:16 -0700 (PDT) [thread overview]
Message-ID: <20070416.171016.43503207.davem@davemloft.net> (raw)
In-Reply-To: <4623029A.2090906@trash.net>
From: Patrick McHardy <kaber@trash.net>
Date: Mon, 16 Apr 2007 06:59:06 +0200
> RTM_DELROUTE + RTM_NEWROUTE seem to be safer, although you're correct
> that it might cause userspace to perform some action upon receiving
> the DELROUTE message since the update is non-atomic. So I really don't
> know, I'm in favour of having notifications for replacements, but I
> fear we might break something.
We can cry foul about a broken application if an application following
the API correctly would interpret the new messages correctly.
I think it doesn't make sense to do a delete then a newroute for
the atomicity issues, and therefore the replace makes the most
sense as long as existing correct uses of the API would not
explode on this.
next prev parent reply other threads:[~2007-04-17 0:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200704110937.l3B9b1Kp001053@fire-2.osdl.org>
2007-04-11 16:47 ` [Bugme-new] [Bug 8320] New: replacing route in kernel doesn't send netlink message Andrew Morton
2007-04-11 18:19 ` Patrick McHardy
2007-04-12 17:53 ` Milan Kocián
2007-04-16 4:59 ` Patrick McHardy
2007-04-17 0:10 ` David Miller [this message]
2007-04-17 12:58 ` Patrick McHardy
2007-04-18 12:48 ` Milan Kocián
2007-04-18 14:06 ` Patrick McHardy
2007-04-19 11:30 ` Milan Kocián
2007-04-19 12:12 ` Patrick McHardy
2007-04-19 21:42 ` Andrew Morton
2007-04-20 14:07 ` [patch 1/1] networking: fix sending netlink message when replace route Milan Kocian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070416.171016.43503207.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=bugme-daemon@bugzilla.kernel.org \
--cc=kaber@trash.net \
--cc=milon@wq.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).