From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: hch@infradead.org, netdev@vger.kernel.org, keir@xensource.com
Subject: Re: [NET]: Get rid of alloc_skb code duplication
Date: Tue, 17 Apr 2007 12:29:55 -0700 (PDT) [thread overview]
Message-ID: <20070417.122955.48397449.davem@davemloft.net> (raw)
In-Reply-To: <20070417141743.GA21473@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Wed, 18 Apr 2007 00:17:43 +1000
> On Tue, Apr 17, 2007 at 02:03:47PM +0100, Christoph Hellwig wrote:
> >
> > It was put in for Xen, but if you as the resident beat the crap out
> > of Xen networking guru don't know about it we should probably just
> > kill it. Especially as we usually kill dead code pretty fast.
>
> Heh, I wasn't touching Xen back then.
>
> That's good news actually. Xen has now killed their custom alloc_skb
> so this is no longer needed. Besides, even if they needed it they'll
> have to patch it in anyway since you've already killed the ifdef that
> lets them have a custom alloc_skb :)
>
> [NET]: Get rid of alloc_skb_from_cache
>
> Since this was added originally for Xen, and Xen has recently (~2.6.18)
> stopped using this function, we can safely get rid of it. Good timing
> too since this function has started to bit rot.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied. You missed the arch/x86_64/kernel/functionlist reference
but I took care of that for you :-)
I'm going to push this into 2.6.21 because the sooner this dies
the better, even though it will make for some net-2.6.22 merge
hassles for me.
prev parent reply other threads:[~2007-04-17 19:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-17 11:57 [NET]: Get rid of alloc_skb code duplication Herbert Xu
2007-04-17 13:03 ` Christoph Hellwig
2007-04-17 14:17 ` Herbert Xu
2007-04-17 19:29 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070417.122955.48397449.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hch@infradead.org \
--cc=herbert@gondor.apana.org.au \
--cc=keir@xensource.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).