From: Christoph Hellwig <hch@infradead.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [NET]: Get rid of alloc_skb code duplication
Date: Tue, 17 Apr 2007 14:03:47 +0100 [thread overview]
Message-ID: <20070417130347.GA2632@infradead.org> (raw)
In-Reply-To: <20070417115746.GA20287@gondor.apana.org.au>
On Tue, Apr 17, 2007 at 09:57:46PM +1000, Herbert Xu wrote:
> Hi Dave:
>
> [NET]: Get rid of alloc_skb code duplication
>
> The skb initialisation code is shared between alloc_skb and
> alloc_skb_from_cache. Now I don't know what actually uses
> the latter so perhaps we could simply get rid of it.
It was put in for Xen, but if you as the resident beat the crap out
of Xen networking guru don't know about it we should probably just
kill it. Especially as we usually kill dead code pretty fast.
next prev parent reply other threads:[~2007-04-17 13:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-17 11:57 [NET]: Get rid of alloc_skb code duplication Herbert Xu
2007-04-17 13:03 ` Christoph Hellwig [this message]
2007-04-17 14:17 ` Herbert Xu
2007-04-17 19:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070417130347.GA2632@infradead.org \
--to=hch@infradead.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).