netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mitsuru Chinen <mitch@linux.vnet.ibm.com>
To: netdev@vger.kernel.org
Cc: Mitsuru Chinen <mitch@linux.vnet.ibm.com>
Subject: [PATCH 3/6] [IPV4] SNMP: Support InTruncatedPkts
Date: Tue, 17 Apr 2007 20:13:37 +0900	[thread overview]
Message-ID: <20070417201337.3d48b86a.mitch@linux.vnet.ibm.com> (raw)
In-Reply-To: <20070417200944.bd82ded2.mitch@linux.vnet.ibm.com>

An IP datagram which is being discarded because the datagram frame
didn't carry enough data should be counted as InTruncatedPkts.

Signed-off-by: Mitsuru Chinen <mitch@linux.vnet.ibm.com>
---
 net/ipv4/ip_input.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/net/ipv4/ip_input.c b/net/ipv4/ip_input.c
index 63ab523..c8c455d 100644
--- a/net/ipv4/ip_input.c
+++ b/net/ipv4/ip_input.c
@@ -416,7 +416,10 @@ int ip_rcv(struct sk_buff *skb, struct n
 		goto inhdr_error;
 
 	len = ntohs(iph->tot_len);
-	if (skb->len < len || len < (iph->ihl*4))
+	if (skb->len < len) {
+		IP_INC_STATS_BH(IPSTATS_MIB_INTRUNCATEDPKTS);
+		goto drop;
+	} else if (len < (iph->ihl*4))
 		goto inhdr_error;
 
 	/* Our transport medium may have padded the buffer out. Now we know it
-- 
1.4.3.4


  parent reply	other threads:[~2007-04-17 11:13 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-17 11:09 [PATCH 0/6] SNMP: new statistics specified in RFC4293 Mitsuru Chinen
2007-04-17 11:12 ` [PATCH 1/6] SNMP: Add definitions for {In,Out}BcastPkts Mitsuru Chinen
2007-04-30  7:48   ` David Miller
2007-04-17 11:13 ` [PATCH 2/6] [IPV4] SNMP: Support InNoRoutes Mitsuru Chinen
2007-04-30  7:49   ` David Miller
2007-04-17 11:13 ` Mitsuru Chinen [this message]
2007-04-30  7:49   ` [PATCH 3/6] [IPV4] SNMP: Support InTruncatedPkts David Miller
2007-04-17 11:13 ` [PATCH 4/6] [IPV4] SNMP: Support InMcastPkts and InBcastPkts Mitsuru Chinen
2007-04-30  7:49   ` David Miller
2007-04-17 11:14 ` [PATCH 5/6] [IPV4] SNMP: Support OutMcastPkts and OutBcastPkts Mitsuru Chinen
2007-04-30  7:49   ` David Miller
2007-04-17 11:14 ` [PATCH 6/6] [IPV4] SNMP: Display new statistics at /proc/net/snmp Mitsuru Chinen
2007-04-27  7:46   ` Mitsuru Chinen
2007-04-30  7:50     ` David Miller
2007-05-02  1:05       ` Mitsuru Chinen
2007-05-03 10:15         ` David Miller
2007-05-07 11:29           ` Mitsuru Chinen
2007-05-11 16:10             ` Mitsuru Chinen
2007-05-11 16:19               ` YOSHIFUJI Hideaki / 吉藤英明
2007-05-14 10:07                 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070417201337.3d48b86a.mitch@linux.vnet.ibm.com \
    --to=mitch@linux.vnet.ibm.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).