From: David Miller <davem@davemloft.net>
To: samuel@sortiz.org
Cc: netdev@vger.kernel.org, irda-users@lists.sourceforge.net,
olaf.kirch@oracle.com, stable@kernel.org
Subject: Re: [PATCH] [net-2.6] IrDA: Correctly handling socket error
Date: Wed, 18 Apr 2007 15:07:56 -0700 (PDT) [thread overview]
Message-ID: <20070418.150756.122832779.davem@davemloft.net> (raw)
In-Reply-To: <20070418214526.GA4496@sortiz.org>
From: Samuel Ortiz <samuel@sortiz.org>
Date: Thu, 19 Apr 2007 00:45:26 +0300
> From: Olaf Kirch <olaf.kirch@oracle.com>
>
> This patch fixes an oops first reported in mid 2006 - see
> http://lkml.org/lkml/2006/8/29/358 The cause of this bug report is that
> when an error is signalled on the socket, irda_recvmsg_stream returns
> without removing a local wait_queue variable from the socket's sk_sleep
> queue. This causes havoc further down the road.
>
> In response to this problem, a patch was made that invoked sock_orphan on
> the socket when receiving a disconnect indication. This is not a good fix,
> as this sets sk_sleep to NULL, causing applications sleeping in recvmsg
> (and other places) to oops.
>
> This is against the latest net-2.6 and should be considered for -stable
> inclusion.
>
> Signed-off-by: Olaf Kirch <olaf.kirch@oracle.com>
> Signed-off-by: Samuel Ortiz <samuel@sortiz.org>
Applied and I'll push this to -stable too, thanks!
prev parent reply other threads:[~2007-04-18 22:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-18 21:45 [PATCH] [net-2.6] IrDA: Correctly handling socket error Samuel Ortiz
2007-04-18 22:07 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070418.150756.122832779.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=irda-users@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=olaf.kirch@oracle.com \
--cc=samuel@sortiz.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).