From: Andrew Morton <akpm@linux-foundation.org>
To: netdev@vger.kernel.org
Cc: "bugme-daemon@kernel-bugs.osdl.org"
<bugme-daemon@bugzilla.kernel.org>,
matthias.kaehlcke@gmail.com, khc@pm.waw.pl
Subject: Re: [Bugme-new] [Bug 8330] New: lmc: copy_to/from_user cals while spinlock is held
Date: Fri, 20 Apr 2007 15:56:59 -0700 [thread overview]
Message-ID: <20070420155659.099dad03.akpm@linux-foundation.org> (raw)
In-Reply-To: <200704152128.l3FLSgOB026277@fire-2.osdl.org>
On Sun, 15 Apr 2007 14:28:42 -0700
bugme-daemon@bugzilla.kernel.org wrote:
> http://bugzilla.kernel.org/show_bug.cgi?id=8330
>
> Summary: lmc: copy_to/from_user cals while spinlock is held
> Kernel Version: 2.6.20
> Status: NEW
> Severity: normal
> Owner: jgarzik@pobox.com
> Submitter: matthias.kaehlcke@gmail.com
>
>
> Problem Description:
>
> the lmc_ioctl() function in drivers/net/wan/lmc/lmc_main.c calls
> copy_from/to_user() while the spinlock sc->lmc_lock is held. AFAIK this should
> not be done as copy_from/to_user() might sleep
>
urgh. That function is a study in "what not to do while holding a spinlock".
Including "return without having unlocked it".
It is irreparable.
parent reply other threads:[~2007-04-20 22:57 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <200704152128.l3FLSgOB026277@fire-2.osdl.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070420155659.099dad03.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bugme-daemon@bugzilla.kernel.org \
--cc=khc@pm.waw.pl \
--cc=matthias.kaehlcke@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).