From: Andrew Morton <akpm@linux-foundation.org>
To: netdev@vger.kernel.org
Subject: netlink locking warnings in 2.6.21-rc7-mm1
Date: Tue, 24 Apr 2007 12:42:50 -0700 [thread overview]
Message-ID: <20070424124250.d55789cd.akpm@linux-foundation.org> (raw)
http://test.kernel.org/abat/84786/debug/console.log is saying
Starting udevd BUG: at kernel/mutex-debug.c:82 debug_mutex_unlock()
Call Trace:
[<ffffffff80244b71>] debug_mutex_unlock+0x161/0x170
[<ffffffff804b759c>] __mutex_unlock_slowpath+0x5c/0x160
[<ffffffff80467902>] netlink_dump+0x82/0x1e0
[<ffffffff8046a042>] netlink_dump_start+0x142/0x180
[<ffffffff80461be0>] rtnl_dump_ifinfo+0x0/0x90
[<ffffffff80461be0>] rtnl_dump_ifinfo+0x0/0x90
[<ffffffff80461e26>] rtnetlink_rcv_msg+0xe6/0x240
[<ffffffff80461d40>] rtnetlink_rcv_msg+0x0/0x240
[<ffffffff80468bf9>] netlink_run_queue+0xb9/0x140
[<ffffffff80461cc4>] rtnetlink_rcv+0x34/0x60
[<ffffffff804690b2>] netlink_data_ready+0x12/0x50
[<ffffffff80467bbb>] netlink_sendskb+0x2b/0x50
[<ffffffff80468fc1>] netlink_sendmsg+0x221/0x300
[<ffffffff8044d1cb>] sock_sendmsg+0xcb/0x100
[<ffffffff8023f420>] autoremove_wake_function+0x0/0x30
[<ffffffff80262d62>] __handle_mm_fault+0x1d2/0x8b0
[<ffffffff8044c17e>] move_addr_to_kernel+0x2e/0x40
[<ffffffff8044d5f6>] sys_sendto+0x146/0x1b0
[<ffffffff8044dd6d>] move_addr_to_user+0x5d/0x70
[<ffffffff8044e34b>] sys_getsockname+0xcb/0xe0
[<ffffffff80209b5e>] system_call+0x7e/0x83
which is
static int netlink_dump(struct sock *sk)
{
...
len = cb->dump(skb, cb);
if (len > 0) {
--> mutex_unlock(nlk->cb_mutex);
skb_queue_tail(&sk->sk_receive_queue, skb);
sk->sk_data_ready(sk, len);
return 0;
}
and
void debug_mutex_unlock(struct mutex *lock)
{
if (unlikely(!debug_locks))
return;
--> DEBUG_LOCKS_WARN_ON(lock->owner != current_thread_info());
DEBUG_LOCKS_WARN_ON(lock->magic != lock);
so it's complaining that cb_mutex is being release by a thread other than
the one which acquired it. I'm unable to reproduce it with their config,
naturally.
Can anyone see any conceivable way in which this can happen? There's some
moderately tricky-looking rewriting of the ->cb_mutex pointer happening in
there. If that were to happen concurrently then this might happen?
otoh, we're seeing several fairly unrelated whacko things coming out of the
lock debugging code in that kernel and I'm wondering if there's some common
bug which is causing false positives.
next reply other threads:[~2007-04-24 19:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-24 19:42 Andrew Morton [this message]
2007-04-24 21:20 ` netlink locking warnings in 2.6.21-rc7-mm1 David Miller
2007-04-24 21:26 ` Andrew Morton
2007-04-25 1:06 ` Herbert Xu
2007-04-25 13:17 ` Patrick McHardy
2007-04-25 19:44 ` Andrew Morton
2007-04-25 20:51 ` Patrick McHardy
2007-04-25 21:01 ` David Miller
2007-04-25 23:48 ` Andrew Morton
2007-04-25 13:14 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070424124250.d55789cd.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).