From: Eric Dumazet <dada1@cosmosbay.com>
To: "YOSHIFUJI Hideaki / ____________" <yoshfuji@linux-ipv6.org>
Cc: bunk@stusta.de, davem@davemloft.net, shemminger@osdl.org,
netdev@vger.kernel.org, tglx@linutronix.de
Subject: Re: [net-2.6.22] [TCP]: Fix linkage errors.
Date: Tue, 24 Apr 2007 18:38:27 +0200 [thread overview]
Message-ID: <20070424183827.adb60ae0.dada1@cosmosbay.com> (raw)
In-Reply-To: <20070425.011028.113320997.yoshfuji@linux-ipv6.org>
On Wed, 25 Apr 2007 01:10:28 +0900 (JST)
YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org> wrote:
> How about this?
>
>
> +static inline s64 ktime_to_us(const ktime_t kt)
> +{
> + struct timeval tv = ktime_to_timeval(kt);
> + return tv.tv_sec * USEC_PER_SEC + tv.tv_usec;
> +}
> +
Well, I am afraid it's not 100% correct.
If you really want to return s64 you should do
return (s64) tv.tv_sec * USEC_PER_SEC + tv.tv_usec;
But then it might be overkill to compute a full s64 for TCP use, since we use u32 vrtt
next prev parent reply other threads:[~2007-04-24 16:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-24 15:17 [net-2.6.22] [TCP]: Fix linkage errors YOSHIFUJI Hideaki / 吉藤英明
2007-04-24 15:53 ` Adrian Bunk
2007-04-24 15:58 ` YOSHIFUJI Hideaki / 吉藤英明
2007-04-24 16:10 ` YOSHIFUJI Hideaki / 吉藤英明
2007-04-24 16:38 ` Eric Dumazet [this message]
2007-04-24 17:04 ` [PATCH] Fix build errors on 32bit platforms with new ktime Stephen Hemminger
2007-04-24 18:19 ` Adrian Bunk
2007-04-24 18:48 ` Eric Dumazet
2007-04-24 21:54 ` David Miller
2007-04-24 21:55 ` YOSHIFUJI Hideaki / 吉藤英明
2007-04-24 21:57 ` Stephen Hemminger
2007-04-24 22:12 ` Eric Dumazet
2007-04-24 22:29 ` Stephen Hemminger
2007-04-24 22:15 ` Thomas Gleixner
2007-04-24 22:49 ` YOSHIFUJI Hideaki / 吉藤英明
2007-04-24 23:22 ` David Miller
2007-04-24 16:03 ` [net-2.6.22] [TCP]: Fix linkage errors Eric Dumazet
2007-04-24 18:17 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070424183827.adb60ae0.dada1@cosmosbay.com \
--to=dada1@cosmosbay.com \
--cc=bunk@stusta.de \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
--cc=tglx@linutronix.de \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).