Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: shani.moideen@wipro.com
Cc: kuznet@ms2.inr.ac.ru, pekkas@netcore.fi, jmorris@namei.org,
	yoshfuji@linux-ipv6.org, kaber@coreworks.de,
	netdev@vger.kernel.org, kernel-janitors@lists.osdl.org
Subject: Re: [PATCH]:Replace with time_before in net/ipv4/ipip.c
Date: Wed, 25 Apr 2007 01:19:38 -0700 (PDT)	[thread overview]
Message-ID: <20070425.011938.74750660.davem@davemloft.net> (raw)
In-Reply-To: <1177480813.27118.17.camel@shani-win>

From: Shani Moideen <shani.moideen@wipro.com>
Date: Wed, 25 Apr 2007 11:30:13 +0530

> Replacing (jiffies - errtime < TIMEOUT) with time_before in net/ipv4/ipip.c
> 
> thanks.
> 
> Signed-off-by: Shani Moideen <shani.moideen@wipro.com>

The test you are replacing actually gives a larger window
of acceptance than time_before() does.

It's been a long standing issue whether we should give up
this semantic advantage for the sake of code cleanliness
in the networking code.


      reply	other threads:[~2007-04-25  8:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-25  6:00 [PATCH]:Replace with time_before in net/ipv4/ipip.c Shani Moideen
2007-04-25  8:19 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070425.011938.74750660.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=jmorris@namei.org \
    --cc=kaber@coreworks.de \
    --cc=kernel-janitors@lists.osdl.org \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=netdev@vger.kernel.org \
    --cc=pekkas@netcore.fi \
    --cc=shani.moideen@wipro.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox