From: David Miller <davem@davemloft.net>
To: kuznet@ms2.inr.ac.ru
Cc: security@kernel.org, greg@kroah.com, netdev@vger.kernel.org,
jaco@kroon.co.za
Subject: Re: [PATCH] infinite recursion in netlink
Date: Wed, 25 Apr 2007 13:09:32 -0700 (PDT) [thread overview]
Message-ID: <20070425.130932.70219336.davem@davemloft.net> (raw)
In-Reply-To: <20070425183856.GA6028@ms2.inr.ac.ru>
From: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Date: Wed, 25 Apr 2007 22:38:56 +0400
> Reply to NETLINK_FIB_LOOKUP messages were misrouted back to kernel,
> which resulted in infinite recursion and stack overflow.
>
> The bug is present in all kernel versions since the feature appeared.
>
> The patch also makes some minimal cleanup:
>
> 1. Return something consistent (-ENOENT) when fib table is missing
> 2. Do not crash when queue is empty (does not happen, but yet)
> 3. Put result of lookup
>
> Signed-off-by: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Applied, thanks a lot Alexey.
next prev parent reply other threads:[~2007-04-25 20:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-25 18:38 [PATCH] infinite recursion in netlink Alexey Kuznetsov
2007-04-25 19:59 ` Greg KH
2007-04-25 20:05 ` David Miller
2007-04-25 22:21 ` Jaco Kroon
2007-04-25 20:09 ` David Miller [this message]
2007-04-25 20:15 ` [Security] " Linus Torvalds
2007-04-25 20:18 ` David Miller
2007-04-26 5:29 ` Greg KH
2007-04-26 5:32 ` David Miller
2007-04-26 5:44 ` Greg KH
2007-04-26 5:48 ` Greg KH
2007-04-26 5:52 ` Chris Wright
2007-04-26 6:26 ` Chris Wright
2007-04-26 6:31 ` David Miller
2007-04-26 6:51 ` Greg KH
2007-04-26 7:02 ` David Miller
2007-04-26 5:37 ` Chris Wright
2007-04-26 15:44 ` [PATCH] [IPV4] nl_fib_lookup: Initialise res.r before fib_res_put(&res) Sergey Vlasov
2007-04-26 16:11 ` Alexey Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070425.130932.70219336.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=greg@kroah.com \
--cc=jaco@kroon.co.za \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=security@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).