From: Oleg Nesterov <oleg@tv-sign.ru>
To: David Howells <dhowells@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Miller <davem@davemloft.net>,
ebiederm@xmission.com, containers@lists.osdl.org,
hch@infradead.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: Getting the new RxRPC patches upstream
Date: Wed, 25 Apr 2007 14:41:45 +0400 [thread overview]
Message-ID: <20070425104145.GA83@tv-sign.ru> (raw)
In-Reply-To: <5461.1177488612@redhat.com>
On 04/25, David Howells wrote:
>
> Oleg Nesterov <oleg@tv-sign.ru> wrote:
>
> > Yes sure. Note that this is documented:
> >
> > /*
> > * Kill off a pending schedule_delayed_work(). Note that the work callback
> > * function may still be running on return from cancel_delayed_work(). Run
> > * flush_workqueue() or cancel_work_sync() to wait on it.
> > */
>
> No, it isn't documented. It says that the *work* callback may be running, but
> does not mention the timer callback. However, just looking at the
> cancellation function source made it clear that this would wait for the timer
> handler to return first.
Ah yes, it says nothing about what the returned value means...
> However, is it worth just making cancel_delayed_work() a void function and not
> returning anything? I'm not sure the return value is very useful.
cancel_rearming_delayed_work() needs this, tty_io.c, probably somebody else.
Oleg.
next prev parent reply other threads:[~2007-04-25 10:42 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <11769696211263-git-send-email-ebiederm@xmission.com>
[not found] ` <m1slawn9eb.fsf@ebiederm.dsl.xmission.com>
[not found] ` <29341.1176975158@redhat.com>
[not found] ` <m1lkgoms4j.fsf@ebiederm.dsl.xmission.com>
2007-04-19 14:18 ` Getting the new RxRPC patches upstream David Howells
2007-04-19 15:50 ` Eric W. Biederman
2007-04-19 16:18 ` David Howells
2007-04-19 19:14 ` Eric W. Biederman
2007-04-19 20:14 ` David Miller
2007-04-20 1:15 ` Herbert Xu
2007-04-20 8:02 ` David Howells
2007-04-20 8:58 ` David Miller
2007-04-20 10:41 ` David Howells
2007-04-20 18:38 ` Andrew Morton
2007-04-20 21:28 ` Oleg Nesterov
2007-04-23 8:32 ` David Howells
2007-04-23 17:11 ` Oleg Nesterov
2007-04-24 13:37 ` David Howells
2007-04-24 14:22 ` Oleg Nesterov
2007-04-24 15:51 ` David Howells
2007-04-24 16:40 ` Oleg Nesterov
2007-04-24 16:58 ` David Howells
2007-04-24 17:33 ` Oleg Nesterov
2007-04-24 18:22 ` David Howells
2007-04-24 19:34 ` Oleg Nesterov
2007-04-25 8:10 ` David Howells
2007-04-25 10:41 ` Oleg Nesterov [this message]
2007-04-25 10:45 ` David Howells
2007-04-25 13:48 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070425104145.GA83@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=akpm@linux-foundation.org \
--cc=containers@lists.osdl.org \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).