From: David Miller <davem@davemloft.net>
To: dtor@insightbb.com
Cc: netdev@vger.kernel.org, ivdoorn@gmail.com,
linville@tuxdriver.com, akpm@linux-foundation.org
Subject: Re: [RFC] RF Kill
Date: Thu, 26 Apr 2007 00:54:57 -0700 (PDT) [thread overview]
Message-ID: <20070426.005457.27951605.davem@davemloft.net> (raw)
In-Reply-To: <20070426.004951.85412315.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Thu, 26 Apr 2007 00:49:51 -0700 (PDT)
> From: Dmitry Torokhov <dtor@insightbb.com>
> Date: Tue, 10 Apr 2007 02:29:31 -0400
>
> > On Tuesday 10 April 2007 01:58, Dmitry Torokhov wrote:
> > > Hi,
> > >
> > > This is a modified version of rfkill patch that provides infrastructure
> > > for controlling state of RF transmitters found on various cards.
> >
> > Well, Andrew found bunch of issues with the patch so here is an
> > updated version...
>
> Patch applied, although one part of the locking is slightly
> suspect:
Actually, I'm reverting this, sorry.
Besides the locking and other issues I pointed out, this
thing won't even link. Please do not test the build with
various configurations when submitting new code like this.
Thanks.
MODPOST 139 modules
WARNING: "input_register_handle" [net/rfkill/rfkill-input.ko] undefined!
WARNING: "input_unregister_handle" [net/rfkill/rfkill-input.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2
next prev parent reply other threads:[~2007-04-26 7:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-10 5:58 [RFC] RF Kill Dmitry Torokhov
2007-04-10 6:29 ` Dmitry Torokhov
2007-04-26 7:49 ` David Miller
2007-04-26 7:54 ` David Miller [this message]
2007-04-26 8:00 ` Andrew Morton
2007-04-26 12:45 ` Dmitry Torokhov
2007-05-07 5:03 ` Dmitry Torokhov
2007-04-26 12:52 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070426.005457.27951605.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=dtor@insightbb.com \
--cc=ivdoorn@gmail.com \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).