From: David Miller <davem@davemloft.net>
To: jt@hpl.hp.com
Cc: mb@bu3sch.de, johannes@sipsolutions.net, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 7/9] wext: reduce inline abuse
Date: Thu, 26 Apr 2007 14:37:01 -0700 (PDT) [thread overview]
Message-ID: <20070426.143701.131919386.davem@davemloft.net> (raw)
In-Reply-To: <20070426171517.GA22667@bougret.hpl.hp.com>
From: Jean Tourrilhes <jt@hpl.hp.com>
Date: Thu, 26 Apr 2007 10:15:17 -0700
> On Thu, Apr 26, 2007 at 07:03:27PM +0200, Michael Buesch wrote:
> >
> > Sure, other people have different opinions on that, but I think
> > with my approach we get smallest code with good speed.
>
> Try with gcc-3.3 if you don't trust me. Your patch will
> produce bigger and slower code. Thanks.
A broken compiler is not an argument for keeping all of these
bogus inlines around.
It is the compilers job to optimize things correctly, and current
gcc's do.
We've always had this approach to dealing with compiler "issues".
next prev parent reply other threads:[~2007-04-26 21:36 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-24 18:07 [PATCH 0/9] various wext cleanups Johannes Berg
2007-04-24 18:07 ` [PATCH 1/9] wext: move to net/wireless Johannes Berg
2007-04-24 18:07 ` [PATCH 2/9] wext: clean up how wext is called Johannes Berg
2007-04-24 18:07 ` [PATCH 3/9] wext: remove dead debug code Johannes Berg
[not found] ` <20070424180847.982382000-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2007-04-26 16:46 ` Jean Tourrilhes
[not found] ` <20070426164632.GA22576-yAE0UhLNZJawPNPzzlOzwdBPR1lH4CV8@public.gmane.org>
2007-04-27 0:55 ` John W. Linville
2007-04-24 18:07 ` [PATCH 4/9] wext: remove options Johannes Berg
2007-04-24 18:07 ` [PATCH 5/9] wext: cleanup early ioctl call path Johannes Berg
2007-04-24 18:07 ` [PATCH 6/9] wext: move EXPORT_SYMBOL statements where they belong Johannes Berg
2007-04-24 18:07 ` [PATCH 7/9] wext: reduce inline abuse Johannes Berg
2007-04-26 16:50 ` Jean Tourrilhes
2007-04-26 17:03 ` Michael Buesch
[not found] ` <200704261903.27932.mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
2007-04-26 17:15 ` Jean Tourrilhes
2007-04-26 21:37 ` David Miller [this message]
[not found] ` <20070426165032.GB22576-yAE0UhLNZJawPNPzzlOzwdBPR1lH4CV8@public.gmane.org>
2007-04-26 17:14 ` Johannes Berg
2007-04-24 18:07 ` [PATCH 8/9] wext: misc code cleanups Johannes Berg
2007-04-24 18:07 ` [PATCH 9/9] net_device: dont include wext bits if not required Johannes Berg
[not found] ` <20070424180850.595757000-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2007-04-26 16:53 ` Jean Tourrilhes
2007-04-26 17:08 ` Johannes Berg
[not found] ` <20070426165304.GC22576-yAE0UhLNZJawPNPzzlOzwdBPR1lH4CV8@public.gmane.org>
2007-04-27 0:50 ` John W. Linville
[not found] ` <20070424180732.371620000-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2007-04-26 10:15 ` [PATCH 0/9] various wext cleanups Johannes Berg
2007-04-26 10:18 ` David Miller
[not found] ` <20070426.031842.17863787.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2007-04-26 11:05 ` Johannes Berg
2007-04-26 10:19 ` David Miller
[not found] ` <20070426.031921.133286083.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2007-04-27 1:12 ` John W. Linville
2007-04-27 2:36 ` David Miller
2007-04-27 3:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070426.143701.131919386.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=jt@hpl.hp.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).