Re: IPV6 source routing patch is still broken?

[David Miller <davem@davemloft.net>]

From: Chuck Ebbert <cebbert@redhat.com>
Date: Thu, 26 Apr 2007 17:53:58 -0400

> Looking at the patch that went into 2.6.20.9, I can't see
> how type 2 packets get through at all. Shouldn't this part
> read:
> 
> +       case IPV6_SRCRT_TYPE_2:
> +               if (accept_source_route >= 0)
> +                       break;
> +               kfree_skb(skb);
> +               return -1;
> +       case IPV6_SRCRT_TYPE_0:
> +               if (accept_source_route > 0)
> +                       break;
> +               kfree_skb(skb);
> +               return -1;

Yes, that looks like it matches the sysctl documentation more closely:

accept_source_route - INTEGER
	Accept source routing (routing extension header).

	> 0: Accept routing header.
	= 0: Accept only routing header type 2.
	< 0: Do not accept routing header.

Type 2 packets should get through as long as the value of the sysctl
is not negative.

Hmmm?