From: Greg KH <greg@kroah.com>
To: David Miller <davem@davemloft.net>
Cc: torvalds@linux-foundation.org, kuznet@ms2.inr.ac.ru,
security@kernel.org, netdev@vger.kernel.org, jaco@kroon.co.za
Subject: Re: [Security] [PATCH] infinite recursion in netlink
Date: Wed, 25 Apr 2007 22:44:20 -0700 [thread overview]
Message-ID: <20070426054420.GA18057@kroah.com> (raw)
In-Reply-To: <20070425.223201.108808547.davem@davemloft.net>
On Wed, Apr 25, 2007 at 10:32:01PM -0700, David Miller wrote:
> From: Greg KH <greg@kroah.com>
> Date: Wed, 25 Apr 2007 22:29:12 -0700
>
> > On Wed, Apr 25, 2007 at 01:15:12PM -0700, Linus Torvalds wrote:
> > >
> > >
> > > On Wed, 25 Apr 2007, Alexey Kuznetsov wrote:
> > > >
> > > > Reply to NETLINK_FIB_LOOKUP messages were misrouted back to kernel,
> > > > which resulted in infinite recursion and stack overflow.
> >
> > Wait, I just had the bright idea of actually testing this before I
> > pushed out a 2.6.20.9 kernel with another fix in it, and nope, still
> > crashes, even with this patch :(
> >
> > Full stackdump in a picture (forgot to have netconsole running) at:
> > http://www.kroah.com/netlink_oops.jpg
> >
> > Any thoughts?
> >
> > I'll go try 2.6.21 now too...
>
> Crap. We should have let this one simmer for a day to get
> more eyes on it.
>
> Thanks for catching this Greg.
Odd, 2.6.21 doesn't crash at all.
Can anyone verify that I made the 2.6.20.8 release correctly with the
proper patch?
thanks,
greg k-h
next prev parent reply other threads:[~2007-04-26 5:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-25 18:38 [PATCH] infinite recursion in netlink Alexey Kuznetsov
2007-04-25 19:59 ` Greg KH
2007-04-25 20:05 ` David Miller
2007-04-25 22:21 ` Jaco Kroon
2007-04-25 20:09 ` David Miller
2007-04-25 20:15 ` [Security] " Linus Torvalds
2007-04-25 20:18 ` David Miller
2007-04-26 5:29 ` Greg KH
2007-04-26 5:32 ` David Miller
2007-04-26 5:44 ` Greg KH [this message]
2007-04-26 5:48 ` Greg KH
2007-04-26 5:52 ` Chris Wright
2007-04-26 6:26 ` Chris Wright
2007-04-26 6:31 ` David Miller
2007-04-26 6:51 ` Greg KH
2007-04-26 7:02 ` David Miller
2007-04-26 5:37 ` Chris Wright
2007-04-26 15:44 ` [PATCH] [IPV4] nl_fib_lookup: Initialise res.r before fib_res_put(&res) Sergey Vlasov
2007-04-26 16:11 ` Alexey Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070426054420.GA18057@kroah.com \
--to=greg@kroah.com \
--cc=davem@davemloft.net \
--cc=jaco@kroon.co.za \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=security@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).