netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Wright <chrisw@sous-sol.org>
To: Greg KH <greg@kroah.com>
Cc: security@kernel.org, netdev@vger.kernel.org, jaco@kroon.co.za,
	kuznet@ms2.inr.ac.ru, torvalds@linux-foundation.org,
	David Miller <davem@davemloft.net>
Subject: Re: [Security] [PATCH] infinite recursion in netlink
Date: Wed, 25 Apr 2007 23:26:01 -0700	[thread overview]
Message-ID: <20070426062601.GH2819@sequoia.sous-sol.org> (raw)
In-Reply-To: <20070426055259.GF2819@sequoia.sous-sol.org>

* Chris Wright (chrisw@sous-sol.org) wrote:
> * Greg KH (greg@kroah.com) wrote:
> > fyi, here's the patch that I applied, perhaps 2.6.20 needed something
> > else too?
> <snip>
> > @@ -809,7 +815,7 @@ static void nl_fib_input(struct sock *sk
> >  
> >  	nl_fib_lookup(frn, tb);
> >  	
> > -	pid = nlh->nlmsg_pid;           /*pid of sending process */
> > +	pid = NETLINK_CB(skb).pid;       /* pid of sending process */
> 
> That's the important bit.  I'm testing against 2.6.20.8 right now.

Working fine here.  Any chance you booted a stale kernel?
If not, what's your nl_fib_input+0xe4.  Any chance that's
actually in nl_fib_lookup?

  reply	other threads:[~2007-04-26  6:28 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-25 18:38 [PATCH] infinite recursion in netlink Alexey Kuznetsov
2007-04-25 19:59 ` Greg KH
2007-04-25 20:05   ` David Miller
2007-04-25 22:21   ` Jaco Kroon
2007-04-25 20:09 ` David Miller
2007-04-25 20:15 ` [Security] " Linus Torvalds
2007-04-25 20:18   ` David Miller
2007-04-26  5:29   ` Greg KH
2007-04-26  5:32     ` David Miller
2007-04-26  5:44       ` Greg KH
2007-04-26  5:48         ` Greg KH
2007-04-26  5:52           ` Chris Wright
2007-04-26  6:26             ` Chris Wright [this message]
2007-04-26  6:31               ` David Miller
2007-04-26  6:51                 ` Greg KH
2007-04-26  7:02                   ` David Miller
2007-04-26  5:37     ` Chris Wright
2007-04-26 15:44     ` [PATCH] [IPV4] nl_fib_lookup: Initialise res.r before fib_res_put(&res) Sergey Vlasov
2007-04-26 16:11       ` Alexey Kuznetsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070426062601.GH2819@sequoia.sous-sol.org \
    --to=chrisw@sous-sol.org \
    --cc=davem@davemloft.net \
    --cc=greg@kroah.com \
    --cc=jaco@kroon.co.za \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=netdev@vger.kernel.org \
    --cc=security@kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).