netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch 01/11] git-netdev-all: export ieee80211_debug_level
@ 2007-04-26  7:23 akpm
  2007-04-26 12:35 ` John W. Linville
  0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2007-04-26  7:23 UTC (permalink / raw)
  To: jeff; +Cc: netdev, akpm, dsd, johannes, josejx

From: Andrew Morton <akpm@linux-foundation.org>

Someone has been forgetting their SubmitChecklist medicine.

ERROR: "ieee80211_debug_level" [net/ieee80211/ieee80211_crypt_ccmp.ko] undefined!

Fix some unneeded space-wasting initialisations, too.  How often must this be
said?

Cc: Johannes Berg <johannes@sipsolutions.net>
Cc: Joe Jezak <josejx@gentoo.org>
Cc: Daniel Drake <dsd@gentoo.org>
Cc: Jeff Garzik <jeff@garzik.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 net/ieee80211/ieee80211_module.c |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff -puN net/ieee80211/ieee80211_module.c~git-netdev-all-export-ieee80211_debug_level net/ieee80211/ieee80211_module.c
--- a/net/ieee80211/ieee80211_module.c~git-netdev-all-export-ieee80211_debug_level
+++ a/net/ieee80211/ieee80211_module.c
@@ -227,9 +227,11 @@ void free_ieee80211(struct net_device *d
 
 #ifdef CONFIG_IEEE80211_DEBUG
 
-static int debug = 0;
-u32 ieee80211_debug_level = 0;
-static struct proc_dir_entry *ieee80211_proc = NULL;
+static int debug;
+u32 ieee80211_debug_level;
+static struct proc_dir_entry *ieee80211_proc;
+
+EXPORT_SYMBOL(ieee80211_debug_level);
 
 static int show_debug_level(char *page, char **start, off_t offset,
 			    int count, int *eof, void *data)
_

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [patch 01/11] git-netdev-all: export ieee80211_debug_level
  2007-04-26  7:23 [patch 01/11] git-netdev-all: export ieee80211_debug_level akpm
@ 2007-04-26 12:35 ` John W. Linville
  0 siblings, 0 replies; 2+ messages in thread
From: John W. Linville @ 2007-04-26 12:35 UTC (permalink / raw)
  To: akpm; +Cc: jeff, netdev, dsd, johannes, josejx

On Thu, Apr 26, 2007 at 12:23:14AM -0700, akpm@linux-foundation.org wrote:
> From: Andrew Morton <akpm@linux-foundation.org>
> 
> Someone has been forgetting their SubmitChecklist medicine.
> 
> ERROR: "ieee80211_debug_level" [net/ieee80211/ieee80211_crypt_ccmp.ko] undefined!

Sent a pull request to Jeff on Tuesday that should fix this.

> Fix some unneeded space-wasting initialisations, too.  How often must this be
> said?

> -static int debug = 0;
> -u32 ieee80211_debug_level = 0;
> -static struct proc_dir_entry *ieee80211_proc = NULL;
> +static int debug;
> +u32 ieee80211_debug_level;
> +static struct proc_dir_entry *ieee80211_proc;

ACK to these bits.

John

-- 
John W. Linville
linville@tuxdriver.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-04-26 12:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-04-26  7:23 [patch 01/11] git-netdev-all: export ieee80211_debug_level akpm
2007-04-26 12:35 ` John W. Linville

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).