From: Matt Mackall <mpm@selenic.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
shemminger@linux-foundation.org
Subject: Re: [PATCH repost] netpoll: trapping fix/cleanup
Date: Fri, 27 Apr 2007 15:27:13 -0500 [thread overview]
Message-ID: <20070427202713.GS11115@waste.org> (raw)
In-Reply-To: <200704272344.00410.sshtylyov@ru.mvista.com>
On Fri, Apr 27, 2007 at 11:44:00PM +0400, Sergei Shtylyov wrote:
> CONFIG_NETPOLL_TRAP causes the TX queue controls to be completely bypassed in
> the netpoll's "trapped" mode which easily causes overflows in the drivers with
> short TX queues (most notably, in 8139too with its 4-deep queue).
> Make this option more sensible by only bypassing TX softirq wakeup and remove
> CONFIG_NETPOLL_RX option completely since there is *no* code depending on it.
You've got two unrelated patches here, so that's an automatic NAK.
I suppose we can kill the config option.
What did you test the NETPOLL_TRAP test with?
--
Mathematics is the supreme nostalgia of our time.
next prev parent reply other threads:[~2007-04-27 20:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-27 19:44 [PATCH repost] netpoll: trapping fix/cleanup Sergei Shtylyov
2007-04-27 20:27 ` Matt Mackall [this message]
2007-04-28 12:56 ` Sergei Shtylyov
2007-04-28 13:00 ` Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070427202713.GS11115@waste.org \
--to=mpm@selenic.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).