netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: jon.maloy@ericsson.com
Cc: netdev@vger.kernel.org, allan.stephens@windriver.com,
	jon.maloy@donjonn.com, per.liden@ericsson.com
Subject: Re: [PATCH] [TIPC]: Changed msg_set_bits params type
Date: Sat, 28 Apr 2007 21:24:33 -0700 (PDT)	[thread overview]
Message-ID: <20070428.212433.17865830.davem@davemloft.net> (raw)
In-Reply-To: <46313AD2.6060809@ericsson.com>

From: Jon Paul Maloy <jon.maloy@ericsson.com>
Date: Thu, 26 Apr 2007 19:50:42 -0400

> David Miller wrote:
> > Did you actually run sparse to see what warnings this change
> > adds or deletes or are you submitting untested changes?
> >
> >   
> I did, and I am aware that sparse shows several warnings
> for TIPC, which we will have to fix this asap, of course.
> The patched line did not show up in the warning list, which
> along with a full regression test made me conclude that we
> didn't introduce a problem, at least. I see now that it
> didn't cause a warning before the change either, so I was
> probably too quick to try to please people. You can can
> ignore the patch if you want to, but it is safe.

Thanks for clarifying, but your email client corrupted the patch by
mangling the whitespace and adding newlines to break up long lines.

I feel like I write this to somebody every single day, but
could you please email patches to yourself and test that
they actually apply instead of wasting my time like this?

      reply	other threads:[~2007-04-29  4:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-26 19:57 [PATCH] [TIPC]: Changed msg_set_bits params type Jon Paul Maloy
2007-04-26 21:45 ` David Miller
2007-04-26 23:50   ` Jon Paul Maloy
2007-04-29  4:24     ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070428.212433.17865830.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=allan.stephens@windriver.com \
    --cc=jon.maloy@donjonn.com \
    --cc=jon.maloy@ericsson.com \
    --cc=netdev@vger.kernel.org \
    --cc=per.liden@ericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).