From: Andrew Morton <akpm@linux-foundation.org>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: linux-mips@linux-mips.org, netdev@vger.kernel.org,
jeff@garzik.org, ralf@linux-mips.org, sshtylyov@ru.mvista.com
Subject: Re: [PATCH 1/3] ne: Add platform_driver
Date: Sat, 28 Apr 2007 00:57:27 -0700 [thread overview]
Message-ID: <20070428005727.6414a24e.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070425.015450.25909765.anemo@mba.ocn.ne.jp>
On Wed, 25 Apr 2007 01:54:50 +0900 (JST) Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
> @@ -880,4 +964,7 @@ void __exit cleanup_module(void)
> }
> }
> }
> +#else /* MODULE */
> +module_init(ne_init);
> +module_exit(ne_exit);
> #endif /* MODULE */
Are we sure about this part? It is unusual to have special treatment dependent
upon MODULE.
next prev parent reply other threads:[~2007-04-28 7:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-24 16:54 [PATCH 1/3] ne: Add platform_driver Atsushi Nemoto
2007-04-28 7:57 ` Andrew Morton [this message]
2007-04-28 16:40 ` Atsushi Nemoto
2007-04-28 15:07 ` Jeff Garzik
2007-04-28 17:12 ` Atsushi Nemoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070428005727.6414a24e.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=anemo@mba.ocn.ne.jp \
--cc=jeff@garzik.org \
--cc=linux-mips@linux-mips.org \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).