From: olof@lixom.net (Olof Johansson)
To: Jeff Garzik <jgarzik@pobox.com>
Cc: netdev@vger.kernel.org
Subject: Re: [RESEND] [PATCH v2] [1/5] pasemi_mac: minor bugfixes
Date: Sat, 28 Apr 2007 11:17:25 -0500 [thread overview]
Message-ID: <20070428161725.GA2442@lixom.net> (raw)
In-Reply-To: <46336631.9070501@pobox.com>
On Sat, Apr 28, 2007 at 11:20:17AM -0400, Jeff Garzik wrote:
> >+ if (was_full)
> >+ netif_wake_queue(mac->netdev);
> >+
>
> Isn't this was_full check redundant? Using standard test-and-clear
> atomic logic, netif_wake_queue() will not issue spurious wakeups. Take
> a look at its implementation in include/linux/netdevice.h.
It's not needed to avoid spurious wakeups, but test_and_clear_bit()
results in an atomic op even if the bit is already clear. I.e. it's a
bit heavy-handed to do if you can already know that it isn't set.
Either way it's no big deal, I'll take out the test for now. It can always
be added back in if it starts to climb on profiles when benchmarking.
-Olof
next prev parent reply other threads:[~2007-04-28 16:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-28 5:49 [RESEND] [PATCH v2] [0/5] pasemi_mac: fixes and enhancements Olof Johansson
2007-04-28 5:50 ` [RESEND] [PATCH v2] [1/5] pasemi_mac: minor bugfixes Olof Johansson
2007-04-28 15:20 ` Jeff Garzik
2007-04-28 16:17 ` Olof Johansson [this message]
2007-04-28 5:50 ` [RESEND] [PATCH v2] [2/5] pasemi_mac: irq mapping changes Olof Johansson
2007-04-28 5:51 ` [RESEND] [PATCH v2] [3/5] pasemi_mac: cleanups and rx performance improvements Olof Johansson
2007-04-28 15:22 ` Jeff Garzik
2007-04-28 20:08 ` Olof Johansson
2007-04-28 5:51 ` [RESEND] [PATCH v2] [4/5] pasemi_mac: phy support Olof Johansson
2007-04-28 15:23 ` Jeff Garzik
2007-04-28 20:09 ` Olof Johansson
2007-04-28 5:52 ` [RESEND] [PATCH v2] [5/5] pasemi_mac: use local-mac-address Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070428161725.GA2442@lixom.net \
--to=olof@lixom.net \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).