From: Russell King <rmk@arm.linux.org.uk>
To: Vitaly Wool <vwool@ru.mvista.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
dustin@sensoria.com, netdev@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] fix smc911x compilation breakage
Date: Sun, 29 Apr 2007 09:05:12 +0100 [thread overview]
Message-ID: <20070429080512.GA855@flint.arm.linux.org.uk> (raw)
In-Reply-To: <1177783857.1532.4.camel@barja>
On Sat, Apr 28, 2007 at 10:10:57PM +0400, Vitaly Wool wrote:
> Hello Jeff,
>
> > Vitaly Wool wrote:
> > > Index: linux-2.6/drivers/net/smc911x.c
> > > ===================================================================
> > > --- linux-2.6.orig/drivers/net/smc911x.c
> > > +++ linux-2.6/drivers/net/smc911x.c
> > > @@ -75,9 +75,9 @@ static const char version[] =
> > > #include <linux/netdevice.h>
> > > #include <linux/etherdevice.h>
> > > #include <linux/skbuff.h>
> > > +#include <linux/irq.h>
> > >
> > > #include <asm/io.h>
> > > -#include <asm/irq.h>
> > >
> > > #include "smc911x.h"
> >
> > This seems to clash with rmk's comment at the top of linux/irq.h?
>
> In a way, yes, but I just was fixing the compilation problem, and not
> changing the logic in any way. The driver currently calls set_irq_type
> so it has to include linux/irq.h, just as it had to include asm/irq.h
> before.
>
> I'd guess that set_irq_type better be called by generic code and either
> just make the driver don't even bother or call a callback set by
> platform part. If you're fine with any of these, and think it's better
> than the initial patch, please let me know and I'll proceed with that.
Drivers should really be using IRQF_TRIGGER_* constants, not set_irq_type()
unless they have a very good reason. I doubt this driver has such a
reason, and it's just coded for an older version of the ARM IRQ API.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next prev parent reply other threads:[~2007-04-29 8:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-27 10:35 [PATCH] fix smc911x compilation breakage Vitaly Wool
2007-04-28 15:33 ` Jeff Garzik
2007-04-28 18:10 ` Vitaly Wool
2007-04-29 8:05 ` Russell King [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-04-30 16:57 [patch] " Vitaly Wool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070429080512.GA855@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=dustin@sensoria.com \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=vwool@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).