From: David Miller <davem@davemloft.net>
To: jchapman@katalix.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 2/5 2.6.21-rc7] l2tp: pppol2tp changes to existing ppp kernel headers
Date: Mon, 30 Apr 2007 00:08:49 -0700 (PDT) [thread overview]
Message-ID: <20070430.000849.55725376.davem@davemloft.net> (raw)
In-Reply-To: <200704231601.l3NG13hW030163@quickie.katalix.com>
From: James Chapman <jchapman@katalix.com>
Date: Mon, 23 Apr 2007 17:01:03 +0100
> Index: linux-2.6.21-rc7/include/linux/if_pppox.h
> ===================================================================
> --- linux-2.6.21-rc7.orig/include/linux/if_pppox.h
> +++ linux-2.6.21-rc7/include/linux/if_pppox.h
> @@ -18,7 +18,19 @@
>
>
> #include <asm/types.h>
> +#ifdef __KERNEL__
> #include <asm/byteorder.h>
> +#else
> +#include <endian.h>
> +#include <byteswap.h>
> +#if __BYTE_ORDER == __LITTLE_ENDIAN
> +#define __LITTLE_ENDIAN_BITFIELD
> +#elif __BYTE_ORDER == __BIG_ENDIAN
> +#define __BIG_ENDIAN_BITFIELD
> +#else
> +#error "Adjust your <endian.h> defines."
> +#endif
> +#endif
Please don't do this, doubly especially without a changelog comment
explaining why.
No other kernel header has to accomodate userland issues like this, so
please find another way that doesn't involve crapping up the in-kernel
header files.
Thanks.
next prev parent reply other threads:[~2007-04-30 7:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-23 16:01 [PATCH 2/5 2.6.21-rc7] l2tp: pppol2tp changes to existing ppp kernel headers James Chapman
2007-04-23 16:21 ` Dale Farnsworth
2007-04-30 7:08 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-04-23 12:56 James Chapman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070430.000849.55725376.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jchapman@katalix.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).