From: David Miller <davem@davemloft.net>
To: jchapman@katalix.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 3/5 2.6.21-rc7] l2tp: pppol2tp core
Date: Mon, 30 Apr 2007 00:18:48 -0700 (PDT) [thread overview]
Message-ID: <20070430.001848.10298399.davem@davemloft.net> (raw)
In-Reply-To: <200704231601.l3NG13TN030167@quickie.katalix.com>
From: James Chapman <jchapman@katalix.com>
Date: Mon, 23 Apr 2007 17:01:03 +0100
> [L2TP]: Add PPP-over-L2TP driver core.
>
> This driver handles only L2TP data frames; control frames are handled
> by a userspace application. It implements L2TP using the PPPoX socket
> family. Data is sent or received using regular socket sendmsg() /
> recvmsg() calls. Kernel parameters of the socket can be read or
> modified using ioctl() or [gs]etsockopt() calls.
>
> Signed-off-by: James Chapman <jchapman@katalix.com>
I have no major objections to this patch.
It is certainly verbose and could stand a lot of cleanup
and debug code removal, but it's functional and has no
glaring abuses of the networking.
Please fixup patch #2 so I can apply this one.
Thanks.
prev parent reply other threads:[~2007-04-30 7:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-23 16:01 [PATCH 3/5 2.6.21-rc7] l2tp: pppol2tp core James Chapman
2007-04-24 16:01 ` Patrick McHardy
2007-04-24 19:17 ` James Chapman
2007-04-26 15:16 ` Patrick McHardy
2007-04-26 22:11 ` James Chapman
2007-04-30 7:18 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070430.001848.10298399.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jchapman@katalix.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).