From: David Miller <davem@davemloft.net>
To: andi@firstfloor.org
Cc: dada1@cosmosbay.com, yoshfuji@linux-ipv6.org, netdev@vger.kernel.org
Subject: Re: [RFC, PATCH] IPV6 : add 64 bits components in struct in6_addr to speedup ipv6_addr_equal() & ipv6_addr_any()
Date: Mon, 30 Apr 2007 13:37:49 -0700 (PDT) [thread overview]
Message-ID: <20070430.133749.41636290.davem@davemloft.net> (raw)
In-Reply-To: <p73bqh5zgv7.fsf@bingen.suse.de>
From: Andi Kleen <andi@firstfloor.org>
Date: 30 Apr 2007 23:34:20 +0200
> David Miller <davem@davemloft.net> writes:
> >
> > Unfortunately, as mentioned elsewhere, we're only able to assume
> > 32-bit alignment of ipv6 packet headers and that isn't likely to
> > change any time soon.
>
> On x86 it would be fine at least -- unaligned access is cheap. I believe
> the same is true for POWER4/5/s390x. Should it be made conditional perhaps?
We have that conditional, it's callet {get,put}_unaligned() but it's
better to fix the infrastructure so that conditionalization isn't
even needed.
prev parent reply other threads:[~2007-04-30 20:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-30 14:28 [RFC, PATCH] IPV6 : add 64 bits components in struct in6_addr to speedup ipv6_addr_equal() & ipv6_addr_any() Eric Dumazet
2007-04-30 16:09 ` YOSHIFUJI Hideaki / 吉藤英明
2007-04-30 16:27 ` Brian Haley
2007-04-30 18:59 ` David Miller
2007-04-30 19:08 ` Eric Dumazet
2007-04-30 19:22 ` David Miller
2007-04-30 19:10 ` David Miller
2007-04-30 21:34 ` Andi Kleen
2007-04-30 20:37 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070430.133749.41636290.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andi@firstfloor.org \
--cc=dada1@cosmosbay.com \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).