From: David Miller <davem@davemloft.net>
To: ilpo.jarvinen@helsinki.fi
Cc: michal.k.k.piotrowski@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: kernel BUG at include/net/tcp.h:739
Date: Thu, 03 May 2007 03:31:13 -0700 (PDT) [thread overview]
Message-ID: <20070503.033113.25133545.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0705030841140.3607@kivilampi-30.cs.helsinki.fi>
From: "Ilpo_Järvinen" <ilpo.jarvinen@helsinki.fi>
Date: Thu, 3 May 2007 09:51:36 +0300 (EEST)
> [PATCH] [TCP]: Use S+L catcher only with SACK for now
>
> TCP has a transitional state when SACK is not in use during
> which this invariant is temporarily broken. Without SACK,
> tcp_clean_rtx_queue does not decrement sacked_out. Therefore
> calls to tcp_sync_left_out before sacked_out is again
> corrected by tcp_fastretrans_alert can trigger this trap as
> sacked_out still has couple of segments that are already out
> of window.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
It would be nice to fix non-SACK as you say, but this is good
enough for now.
next prev parent reply other threads:[~2007-05-03 10:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-02 20:15 kernel BUG at include/net/tcp.h:739 Michal Piotrowski
2007-05-03 6:51 ` Ilpo Järvinen
2007-05-03 10:31 ` David Miller [this message]
2007-05-03 14:07 ` Michal Piotrowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070503.033113.25133545.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.k.k.piotrowski@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).