From: David Miller <davem@davemloft.net>
To: acme@ghostprotocols.net
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH][SOCK]: shrink struct sock
Date: Thu, 03 May 2007 21:22:27 -0700 (PDT) [thread overview]
Message-ID: <20070503.212227.74561366.davem@davemloft.net> (raw)
In-Reply-To: <20070504041101.GA27519@ghostprotocols.net>
From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Date: Fri, 4 May 2007 01:11:01 -0300
>
> This saves 8 bytes out of struct sock in 64bit arches, tested on x86_64.
Thanks I'll apply this.
> Now struct sock has this layout, where we waste more 20 bytes, in four 4 byte
> paddings in struct skb_buff_head members (layout at the bottom) + one 4 bytes
> hole:
sk_buff_head is due for being killed from the whole tree. Nobody
really needs the qlen, few things really need the lock, and those that
do can define their own as needed :-)
There are also cases where we don't even need to dual-linkage so could
decrease it down to one pointer.
next prev parent reply other threads:[~2007-05-04 4:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-04 4:11 [PATCH][SOCK]: shrink struct sock Arnaldo Carvalho de Melo
2007-05-04 4:22 ` David Miller [this message]
2007-05-04 10:17 ` Ian McDonald
2007-05-04 6:10 ` Eric Dumazet
2007-05-04 11:24 ` Arnaldo Carvalho de Melo
2007-05-04 12:24 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070503.212227.74561366.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=acme@ghostprotocols.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).