From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: netfront for review Date: Thu, 3 May 2007 16:17:56 +0100 Message-ID: <20070503151756.GA29629@infradead.org> References: <4637D672.5030706@goop.org> <1178077033.28659.173.camel@localhost.localdomain> <4638EAC0.7020107@goop.org> <46399057.4000409@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jeremy Fitzhardinge , Rusty Russell , lkml - Kernel Mailing List , netdev , Herbert Xu , Keir Fraser To: Gerd Hoffmann Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:48640 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2993244AbXECPSE (ORCPT ); Thu, 3 May 2007 11:18:04 -0400 Content-Disposition: inline In-Reply-To: <46399057.4000409@redhat.com> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Thu, May 03, 2007 at 09:33:43AM +0200, Gerd Hoffmann wrote: > >Guess so. It defaults to flip. I simplified the rx_copy/flip module > >parameter to a simple rx_mode=0/1, but this is preserved from the > >original. My guess is that originally there was only flip, and copy was > >added later. > > Yep, page flipping is the old (pre xen 3.0.3) way, copy was added (and > made the default) later. So can we please just rip out the obsolete code completely? There's no point adding this code anymore.