From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select" Date: Mon, 7 May 2007 13:50:52 -0700 Message-ID: <20070507135052.cc7e74ca.randy.dunlap@oracle.com> References: <463F27CE.2040008@garzik.org> <463F8CB4.3040603@garzik.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Satyam Sharma , Roman Zippel , Krzysztof Halasa , Russell King , lkml , netdev@vger.kernel.org, linux-arm-kernel@lists.arm.linux.org.uk To: Jeff Garzik Return-path: In-Reply-To: <463F8CB4.3040603@garzik.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Mon, 07 May 2007 16:31:48 -0400 Jeff Garzik wrote: > Satyam Sharma wrote: > > Yes, mixing select and depends is a recipe for build disasters. Call > > me a rabid fanatic, but I would in fact go as far as to say that this > > whole "select" thing in the Kconfig process is one big BUG, and not a > > feature. People are lazy by nature and would rather just "select" a > > dependency for their config option than burden users with several > > "depends". > > Tough, the kernel community has voted against you. Andrew (usually) implores people not to use "select" and I agree with him. > It makes far more sense to include a driver during kernel configuration, > and have that driver pull in its libraries via 'select'. The lame > alternative requires developers to know which libraries they need BEFORE > picking their drivers, which is backwards and requires legwork on the > part of the kernel developer. Developers? If you had said "users," I might agree, but IMO it's OK (or even Good) for developers to know what libraries their code uses/requires. Yes, that's a good thing. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***