From: David Miller <davem@davemloft.net>
To: krkumar2@in.ibm.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] sched: Optimize return value of qdisc_restart
Date: Tue, 08 May 2007 19:05:06 -0700 (PDT) [thread overview]
Message-ID: <20070508.190506.85687854.davem@davemloft.net> (raw)
In-Reply-To: <20070508073132.17547.68502.sendpatchset@localhost.localdomain>
From: Krishna Kumar <krkumar2@in.ibm.com>
Date: Tue, 08 May 2007 13:01:32 +0530
> Optimize return value of qdisc_restart so that it is not called an
> extra time if there are no more packets on the queue to be sent out.
> It is also not required to check for gso_skb (though the lock is
> dropped) since another cpu which added this would have done a
> netif_schedule.
>
> Patch against net-2.6.22.git
>
> Signed-off-by: Krishna Kumar <krkumar2@in.ibm.com>
<0 return value here means that the queue is not empty, and the device
is throttled. If you want to do this, just branch down to the end of
the function which asserts that q->q.qlen is not negative, and returns
it.
That will achieve the right effect.
But I'm not so sure about this idea, I have this strange feeling that
we do things this way for a reason... Hmmm...
next prev parent reply other threads:[~2007-05-09 2:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-08 7:31 [PATCH] sched: Optimize return value of qdisc_restart Krishna Kumar
2007-05-09 2:05 ` David Miller [this message]
2007-05-09 4:35 ` Krishna Kumar2
2007-05-09 6:36 ` David Miller
2007-05-09 7:23 ` Krishna Kumar2
2007-05-09 8:12 ` David Miller
2007-05-09 12:56 ` jamal
2007-05-09 14:47 ` Krishna Kumar2
2007-05-09 15:52 ` jamal
2007-05-10 5:12 ` Krishna Kumar2
2007-05-10 11:50 ` Herbert Xu
2007-05-10 11:55 ` David Miller
2007-05-10 12:10 ` Herbert Xu
2007-05-10 21:11 ` David Miller
2007-05-10 12:21 ` jamal
2007-05-10 12:50 ` jamal
2007-05-10 12:59 ` Herbert Xu
2007-05-10 13:18 ` jamal
2007-05-10 13:52 ` Herbert Xu
2007-05-10 14:12 ` jamal
2007-05-10 14:26 ` Krishna Kumar2
2007-05-10 14:31 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070508.190506.85687854.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=krkumar2@in.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).