netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: netdev@vger.kernel.org
Cc: Greg KH <greg@kroah.com>
Subject: [PATCH 12/17] sky2: chip id enum
Date: Tue, 08 May 2007 20:50:01 -0700	[thread overview]
Message-ID: <20070509035030.277026705@linux-foundation.org> (raw)
In-Reply-To: 20070509034949.624934448@linux-foundation.org

[-- Attachment #1: sky2-chip-id-enum --]
[-- Type: text/plain, Size: 1530 bytes --]

Make the chip id value's an enum. This makes it possible for GCC to do
better type checking for us.

Signed-off-by: Stephen Hemmminger <shemminger@linux-foundation.org>

---
 drivers/net/sky2.h |   13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

--- sky2-2.6.21.orig/drivers/net/sky2.h	2007-05-08 15:55:20.000000000 -0700
+++ sky2-2.6.21/drivers/net/sky2.h	2007-05-08 15:56:07.000000000 -0700
@@ -332,24 +332,27 @@ enum {
 };
 
 /*	B2_CHIP_ID		 8 bit 	Chip Identification Number */
-enum {
+enum sky2_chip_id {
 	CHIP_ID_YUKON_XL   = 0xb3, /* Chip ID for YUKON-2 XL */
 	CHIP_ID_YUKON_EC_U = 0xb4, /* Chip ID for YUKON-2 EC Ultra */
 	CHIP_ID_YUKON_EX   = 0xb5, /* Chip ID for YUKON-2 Extreme */
 	CHIP_ID_YUKON_EC   = 0xb6, /* Chip ID for YUKON-2 EC */
  	CHIP_ID_YUKON_FE   = 0xb7, /* Chip ID for YUKON-2 FE */
+};
 
+enum yukon_ec_rev {
 	CHIP_REV_YU_EC_A1    = 0,  /* Chip Rev. for Yukon-EC A1/A0 */
 	CHIP_REV_YU_EC_A2    = 1,  /* Chip Rev. for Yukon-EC A2 */
 	CHIP_REV_YU_EC_A3    = 2,  /* Chip Rev. for Yukon-EC A3 */
-
+};
+enum yukon_ec_u_rev {
 	CHIP_REV_YU_EC_U_A0  = 1,
 	CHIP_REV_YU_EC_U_A1  = 2,
 	CHIP_REV_YU_EC_U_B0  = 3,
-
+};
+enum yukon_fe_rev {
 	CHIP_REV_YU_FE_A1    = 1,
 	CHIP_REV_YU_FE_A2    = 2,
-
 };
 
 /*	B2_Y2_CLK_GATE	 8 bit	Clock Gating (Yukon-2 only) */
@@ -1753,7 +1756,7 @@ struct sky2_hw {
 	struct pci_dev	     *pdev;
 	struct net_device    *dev[2];
 
-	u8	     	     chip_id;
+	enum sky2_chip_id    chip_id;
 	u8		     chip_rev;
 	u8		     pmd_type;
 	u8		     ports;

--


  parent reply	other threads:[~2007-05-09  4:04 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-09  3:49 [PATCH 00/17] sky2 update for 2.6.22 Stephen Hemminger
2007-05-09  3:49 ` [PATCH 01/17] sky2: fix oops on shutdown Stephen Hemminger
2007-05-09  3:49 ` [PATCH 02/17] sky2: dont restrict config space access Stephen Hemminger
2007-05-09  3:49 ` [PATCH 03/17] sky2: keep track of receive alloc failures Stephen Hemminger
2007-05-09  3:49 ` [PATCH 04/17] sky2: remove dual port workaround Stephen Hemminger
2007-05-09  3:49 ` [PATCH 05/17] pci: advanced error reporting stub return values Stephen Hemminger
2007-05-10 15:48   ` Stephen Hemminger
2007-05-09  3:49 ` [PATCH 06/17] sky2: advanced error reporting Stephen Hemminger
2007-05-09 17:05   ` Linas Vepstas
2007-05-09 22:35     ` Stephen Hemminger
2007-05-09  3:49 ` [PATCH 07/17] sky2: use pci_config access functions Stephen Hemminger
2007-05-09  3:49 ` [PATCH 08/17] sky2: MIB counter overflow handling Stephen Hemminger
2007-05-09  3:49 ` [PATCH 09/17] sky2: memory barriers change Stephen Hemminger
2007-05-09  3:49 ` [PATCH 10/17] sky2: add prefetch for next skb on receive Stephen Hemminger
2007-05-09  3:50 ` [PATCH 11/17] sky2: use MII defines Stephen Hemminger
2007-05-09  3:50 ` Stephen Hemminger [this message]
2007-05-09  3:50 ` [PATCH 13/17] sky2: whitespace cleanups Stephen Hemminger
2007-05-09  3:50 ` [PATCH 14/17] pci_wake_enabled function Stephen Hemminger
2007-05-09  3:50 ` [PATCH 15/17] sky2: only disable 88e8056 on some boards Stephen Hemminger
2007-05-09  3:50 ` [PATCH 16/17] sky2: make sure high DMA bits set Stephen Hemminger
2007-05-09  3:50 ` [PATCH 17/17] sky2: version 1.15 Stephen Hemminger
2007-05-09  4:16 ` [PATCH 00/17] sky2 update for 2.6.22 Jeff Garzik
2007-05-09 14:48   ` Stephen Hemminger
2007-05-09 23:27     ` Jeff Garzik
2007-05-10  5:08       ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070509035030.277026705@linux-foundation.org \
    --to=shemminger@linux-foundation.org \
    --cc=jgarzik@pobox.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).