From: Sascha Hauer <s.hauer@pengutronix.de>
To: netdev@vger.kernel.org
Cc: afleming@freescale.com
Subject: bus id in PHY Abstraction Layer
Date: Wed, 9 May 2007 10:45:56 +0200 [thread overview]
Message-ID: <20070509084556.GA5967@localhost.localdomain> (raw)
Hi,
I made a quick shot to port the at91 network driver to the phy
abstraction layer. While doing so I stumbled upon the
(struct mii_bus)->id field. Currently the network driver registering the
bus has to set this field. au1000_eth.c for example uses 0 or 1. mii-fec.c
uses the id field of the corresponding platform device, which will start
from 0, too. So if a second ethernet driver comes around the id fields
will clash. I think the PAL has to assign the id field instead of the
network driver. Maybe a id convention like "mii_fec.x:yy" where x is a
running number and yy is the phy address would do it. Any opinions about
that?
Sascha
--
Pengutronix - Linux Solutions for Science and Industry
Entwicklungszentrum Nord http://www.pengutronix.de
reply other threads:[~2007-05-09 8:46 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070509084556.GA5967@localhost.localdomain \
--to=s.hauer@pengutronix.de \
--cc=afleming@freescale.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox