From: Andi Kleen <andi@firstfloor.org>
To: David Miller <davem@davemloft.net>
Cc: andi@firstfloor.org, rick.jones2@hp.com, netdev@vger.kernel.org,
tglx@linutronix.de, mingo@elte.hu
Subject: Re: smp_affinity, MSI-X and 2.6.21.1
Date: Wed, 9 May 2007 13:50:40 +0200 [thread overview]
Message-ID: <20070509115040.GC15029@one.firstfloor.org> (raw)
In-Reply-To: <20070509.024614.48396047.davem@davemloft.net>
> That's true, but we are talking about software state so in some sense
> it might be better that the affinity-to-be is reported to the user in
> this case.
>
> Delayed register updates are an implementation detail the user does
> not need to know about here.
This patch should fix it.
-Andi
Report the pending irq if available in smp_affinity
Otherwise smp_affinity would only update after the next interrupt
on x86 systems.
Cc: tglx@linutronix.de
Cc: mingo@elte.hu
Signed-off-by: Andi Kleen <ak@suse.de>
Index: linux/kernel/irq/proc.c
===================================================================
--- linux.orig/kernel/irq/proc.c
+++ linux/kernel/irq/proc.c
@@ -19,7 +19,14 @@ static struct proc_dir_entry *root_irq_d
static int irq_affinity_read_proc(char *page, char **start, off_t off,
int count, int *eof, void *data)
{
- int len = cpumask_scnprintf(page, count, irq_desc[(long)data].affinity);
+ struct irq_desc *desc = irq_desc + (long)data;
+ cpumask_t *mask = &desc->affinity;
+ int len;
+#ifdef CONFIG_GENERIC_PENDING_IRQ
+ if (desc->status & IRQ_MOVE_PENDING)
+ mask = &desc->pending_mask;
+#endif
+ len = cpumask_scnprintf(page, count, *mask);
if (count - len < 2)
return -EINVAL;
next prev parent reply other threads:[~2007-05-09 11:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-07 20:53 smp_affinity, MSI-X and 2.6.21.1 Rick Jones
2007-05-07 23:07 ` Arjan van de Ven
2007-05-08 0:09 ` Rick Jones
2007-05-09 10:35 ` Andi Kleen
2007-05-09 9:46 ` David Miller
2007-05-09 11:50 ` Andi Kleen [this message]
2007-05-15 22:52 ` Rick Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070509115040.GC15029@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=davem@davemloft.net \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=rick.jones2@hp.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).