From: Stephen Hemminger <shemminger@linux-foundation.org>
To: linas@austin.ibm.com (Linas Vepstas)
Cc: Jeff Garzik <jgarzik@pobox.com>,
netdev@vger.kernel.org, Greg KH <greg@kroah.com>,
linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: [PATCH 06/17] sky2: advanced error reporting
Date: Wed, 9 May 2007 15:35:32 -0700 [thread overview]
Message-ID: <20070509153532.68adcb46@localhost> (raw)
In-Reply-To: <20070509170551.GW4452@austin.ibm.com>
On Wed, 9 May 2007 12:05:51 -0500
linas@austin.ibm.com (Linas Vepstas) wrote:
> On Tue, May 08, 2007 at 08:49:55PM -0700, Stephen Hemminger wrote:
> > Use the kernel interfaces for advanced error reporting.
> > This should be cleaner and clear up errors on boot.
>
> Hmm. I thought that the AER functions would eventually
> be handled by the struct pci_error_handlers callbacks,
> so that dev drivers wouldn't actually have code such as
No, it doesn't seem to work that way. Those callback seems to
be for bus reported errors, not device reported errors.
> > + pci_read_config_dword(pdev, pos + PCI_ERR_UNCOR_STATUS, &status);
> > + pci_read_config_dword(pdev, pos + PCI_ERR_UNCOR_SEVER, &mask);
>
> in them. But perhaps I haven't studed what this drivr is trying to
> do; nor have I really kept track of the aer code.
>
On boot up it clears errors because power on seems to leave a bogus
error report.
When error is detected, it gets an IRQ and than has to decode it as PCI
error.
Earlier versions of the driver (pre AER) were doing the same thing but
with only minimal handling of errors. Now at least it uses common code.
next prev parent reply other threads:[~2007-05-09 22:35 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-09 3:49 [PATCH 00/17] sky2 update for 2.6.22 Stephen Hemminger
2007-05-09 3:49 ` [PATCH 01/17] sky2: fix oops on shutdown Stephen Hemminger
2007-05-09 3:49 ` [PATCH 02/17] sky2: dont restrict config space access Stephen Hemminger
2007-05-09 3:49 ` [PATCH 03/17] sky2: keep track of receive alloc failures Stephen Hemminger
2007-05-09 3:49 ` [PATCH 04/17] sky2: remove dual port workaround Stephen Hemminger
2007-05-09 3:49 ` [PATCH 05/17] pci: advanced error reporting stub return values Stephen Hemminger
2007-05-10 15:48 ` Stephen Hemminger
2007-05-09 3:49 ` [PATCH 06/17] sky2: advanced error reporting Stephen Hemminger
2007-05-09 17:05 ` Linas Vepstas
2007-05-09 22:35 ` Stephen Hemminger [this message]
2007-05-09 3:49 ` [PATCH 07/17] sky2: use pci_config access functions Stephen Hemminger
2007-05-09 3:49 ` [PATCH 08/17] sky2: MIB counter overflow handling Stephen Hemminger
2007-05-09 3:49 ` [PATCH 09/17] sky2: memory barriers change Stephen Hemminger
2007-05-09 3:49 ` [PATCH 10/17] sky2: add prefetch for next skb on receive Stephen Hemminger
2007-05-09 3:50 ` [PATCH 11/17] sky2: use MII defines Stephen Hemminger
2007-05-09 3:50 ` [PATCH 12/17] sky2: chip id enum Stephen Hemminger
2007-05-09 3:50 ` [PATCH 13/17] sky2: whitespace cleanups Stephen Hemminger
2007-05-09 3:50 ` [PATCH 14/17] pci_wake_enabled function Stephen Hemminger
2007-05-09 3:50 ` [PATCH 15/17] sky2: only disable 88e8056 on some boards Stephen Hemminger
2007-05-09 3:50 ` [PATCH 16/17] sky2: make sure high DMA bits set Stephen Hemminger
2007-05-09 3:50 ` [PATCH 17/17] sky2: version 1.15 Stephen Hemminger
2007-05-09 4:16 ` [PATCH 00/17] sky2 update for 2.6.22 Jeff Garzik
2007-05-09 14:48 ` Stephen Hemminger
2007-05-09 23:27 ` Jeff Garzik
2007-05-10 5:08 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070509153532.68adcb46@localhost \
--to=shemminger@linux-foundation.org \
--cc=greg@kroah.com \
--cc=jgarzik@pobox.com \
--cc=linas@austin.ibm.com \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).