From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Greg KH <greg@kroah.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
netdev@vger.kernel.org, Tom Long Nguyen <tom.l.nguyen@intel.com>,
Zhang Yanmin <yanmin.zhang@intel.com>,
linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: [PATCH 05/17] pci: advanced error reporting stub return values
Date: Thu, 10 May 2007 08:48:25 -0700 [thread overview]
Message-ID: <20070510084825.2a8d3add@freepuppy> (raw)
In-Reply-To: <20070509035028.751938921@linux-foundation.org>
On Tue, 08 May 2007 20:49:54 -0700
Stephen Hemminger <shemminger@linux-foundation.org> wrote:
> The stubs for advanced PCI error reporting are wrong. They don't
> match the function return values. This breaks compilation for any
> driver that tries to use these functions (that's the next sky2 patch).
>
> Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
>
> --- sky2.orig/include/linux/aer.h 2007-05-08 20:36:21.000000000 -0700
> +++ sky2/include/linux/aer.h 2007-05-08 20:38:04.000000000 -0700
> @@ -14,10 +14,10 @@
> extern int pci_disable_pcie_error_reporting(struct pci_dev *dev);
> extern int pci_cleanup_aer_uncorrect_error_status(struct pci_dev *dev);
> #else
> -#define pci_enable_pcie_error_reporting(dev) do { } while (0)
> -#define pci_find_aer_capability(dev) do { } while (0)
> -#define pci_disable_pcie_error_reporting(dev) do { } while (0)
> -#define pci_cleanup_aer_uncorrect_error_status(dev) do { } while (0)
> +#define pci_enable_pcie_error_reporting(dev) (-EINVAL)
> +#define pci_find_aer_capability(dev) (0)
> +#define pci_disable_pcie_error_reporting(dev) (-EINVAL)
> +#define pci_cleanup_aer_uncorrect_error_status(dev) (-EINVAL)
> #endif
>
> #endif //_AER_H_
>
> --
Greg could you put this in as a bug fix now.
I don't think I'll put in the usage of aer funcs until 2.6.22 -mm, but
hopefully this will be fixed by then.
--
Stephen Hemminger <shemminger@linux-foundation.org>
next prev parent reply other threads:[~2007-05-10 15:48 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-09 3:49 [PATCH 00/17] sky2 update for 2.6.22 Stephen Hemminger
2007-05-09 3:49 ` [PATCH 01/17] sky2: fix oops on shutdown Stephen Hemminger
2007-05-09 3:49 ` [PATCH 02/17] sky2: dont restrict config space access Stephen Hemminger
2007-05-09 3:49 ` [PATCH 03/17] sky2: keep track of receive alloc failures Stephen Hemminger
2007-05-09 3:49 ` [PATCH 04/17] sky2: remove dual port workaround Stephen Hemminger
2007-05-09 3:49 ` [PATCH 05/17] pci: advanced error reporting stub return values Stephen Hemminger
2007-05-10 15:48 ` Stephen Hemminger [this message]
2007-05-09 3:49 ` [PATCH 06/17] sky2: advanced error reporting Stephen Hemminger
2007-05-09 17:05 ` Linas Vepstas
2007-05-09 22:35 ` Stephen Hemminger
2007-05-09 3:49 ` [PATCH 07/17] sky2: use pci_config access functions Stephen Hemminger
2007-05-09 3:49 ` [PATCH 08/17] sky2: MIB counter overflow handling Stephen Hemminger
2007-05-09 3:49 ` [PATCH 09/17] sky2: memory barriers change Stephen Hemminger
2007-05-09 3:49 ` [PATCH 10/17] sky2: add prefetch for next skb on receive Stephen Hemminger
2007-05-09 3:50 ` [PATCH 11/17] sky2: use MII defines Stephen Hemminger
2007-05-09 3:50 ` [PATCH 12/17] sky2: chip id enum Stephen Hemminger
2007-05-09 3:50 ` [PATCH 13/17] sky2: whitespace cleanups Stephen Hemminger
2007-05-09 3:50 ` [PATCH 14/17] pci_wake_enabled function Stephen Hemminger
2007-05-09 3:50 ` [PATCH 15/17] sky2: only disable 88e8056 on some boards Stephen Hemminger
2007-05-09 3:50 ` [PATCH 16/17] sky2: make sure high DMA bits set Stephen Hemminger
2007-05-09 3:50 ` [PATCH 17/17] sky2: version 1.15 Stephen Hemminger
2007-05-09 4:16 ` [PATCH 00/17] sky2 update for 2.6.22 Jeff Garzik
2007-05-09 14:48 ` Stephen Hemminger
2007-05-09 23:27 ` Jeff Garzik
2007-05-10 5:08 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070510084825.2a8d3add@freepuppy \
--to=shemminger@linux-foundation.org \
--cc=greg@kroah.com \
--cc=jgarzik@pobox.com \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=netdev@vger.kernel.org \
--cc=tom.l.nguyen@intel.com \
--cc=yanmin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).