From: David Miller <davem@davemloft.net>
To: jarkao2@o2.pl
Cc: akpm@linux-foundation.org, jeff@garzik.org,
netdev@vger.kernel.org, jura@netams.com, paulus@samba.org
Subject: Re: [patch 04/13] ppp_generic: fix lockdep warning
Date: Sun, 13 May 2007 23:39:37 -0700 (PDT) [thread overview]
Message-ID: <20070513.233937.99203647.davem@davemloft.net> (raw)
In-Reply-To: <20070514060700.GA1000@ff.dom.local>
From: Jarek Poplawski <jarkao2@o2.pl>
Date: Mon, 14 May 2007 08:07:00 +0200
> After sending this patch I was a little confused, when next
> lockdep warning report appeared, and I thought - since this is
> not enough, this patch could be dumped. But now I changed my
> mind: there are really many possibilities of strange connections
> between locks taken from vlans, ppp (with pppoe), multicasts etc.
> - that every one possibility less is a gain here.
...
> Of course, later, if somebody will find better solution, they could
> be removed,
I already suggested a better fix, you ignored it.
For each unique netdev type, use a different locking class.
That will fix this forever, anything else is a situation specific
band-aid (but then again isn't that what every lockdep annotation is
:-).
next prev parent reply other threads:[~2007-05-14 6:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-11 5:52 [patch 04/13] ppp_generic: fix lockdep warning akpm
2007-05-11 20:57 ` Jeff Garzik
2007-05-11 21:03 ` David Miller
2007-05-11 21:12 ` Andrew Morton
2007-05-14 6:07 ` Jarek Poplawski
2007-05-14 6:39 ` David Miller [this message]
2007-05-14 7:28 ` Jarek Poplawski
2007-05-14 8:08 ` Jarek Poplawski
2007-05-14 12:51 ` Jarek Poplawski
2007-05-14 9:18 ` David Miller
2007-05-14 10:09 ` Jarek Poplawski
2007-05-15 5:31 ` [PATCH] netdev: lockdep classes in register_netdevice " Jarek Poplawski
2007-05-15 8:49 ` Yuriy N. Shkandybin
2007-05-15 10:05 ` Jarek Poplawski
2007-05-16 5:49 ` Jarek Poplawski
2007-05-15 8:50 ` Yuriy N. Shkandybin
2007-05-16 5:40 ` [PATCH (take 2)] " Jarek Poplawski
2007-05-16 5:47 ` David Miller
2007-05-16 6:17 ` Jarek Poplawski
2007-05-16 6:17 ` David Miller
2007-05-16 7:18 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070513.233937.99203647.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=jarkao2@o2.pl \
--cc=jeff@garzik.org \
--cc=jura@netams.com \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).